You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by jun aoki <ju...@gmail.com> on 2016/04/30 01:57:53 UTC
Review Request 46860: Move RM wizard should update HAWQ related
parameters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-16174
https://issues.apache.org/jira/browse/AMBARI-16174
Repository: ambari
Description
-------
when RM HA is not enabled, following properties should be updated in hawq-site.xml should be updated.
hawq_rm_yarn_address
hawq_rm_yarn_scheduler_address
When RM HA Is enabled and then a RM is moved, following properties in yarn-client.xml should be updated
yarn.resourcemanager.ha
yarn.resourcemanager.scheduler.ha
Diffs
-----
ambari-web/app/controllers/main/service/reassign/step4_controller.js a20aa82
ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 460726b
Diff: https://reviews.apache.org/r/46860/diff/
Testing
-------
Unit test passed
Calling set on destroyed view
27428 tests complete (35 seconds)
154 tests pending
Manually tested
Thanks,
jun aoki
Re: Review Request 46860: Move RM wizard should update HAWQ related
parameters
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131232
-----------------------------------------------------------
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js (line 561)
<https://reviews.apache.org/r/46860/#comment195138>
When RM is there, test if you get the yarn-client and hawq-site configuration with the specific tag, i dont see them being used ?
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js (line 632)
<https://reviews.apache.org/r/46860/#comment195139>
When RM is there, test if you get the yarn-client and hawq-site configuration with the specific tag, i dont see them being used ?
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js (line 683)
<https://reviews.apache.org/r/46860/#comment195140>
if you move the location of removing hawq-site and yarn-client from onLoadConfigsTag, probably you will remove the change here
- bhuvnesh chaudhary
On April 29, 2016, 11:57 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 11:57 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when RM HA is not enabled, following properties should be updated in hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/reassign/step4_controller.js a20aa82
> ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de
> ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 460726b
>
> Diff: https://reviews.apache.org/r/46860/diff/
>
>
> Testing
> -------
>
> Unit test passed
> Calling set on destroyed view
>
> 27428 tests complete (35 seconds)
> 154 tests pending
>
>
> Manually tested
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46860: Move RM wizard should update HAWQ related
parameters
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131230
-----------------------------------------------------------
ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 582)
<https://reviews.apache.org/r/46860/#comment195136>
I think you can move this part to getConfigUrlParams where components impacted by NAMENODE (HBASE, ACCUMULO) are also listed.
Also, it would be better to add them if HAWQ exists instead of putting it as default and later removing it.
- bhuvnesh chaudhary
On April 29, 2016, 11:57 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 11:57 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when RM HA is not enabled, following properties should be updated in hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/reassign/step4_controller.js a20aa82
> ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de
> ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 460726b
>
> Diff: https://reviews.apache.org/r/46860/diff/
>
>
> Testing
> -------
>
> Unit test passed
> Calling set on destroyed view
>
> 27428 tests complete (35 seconds)
> 154 tests pending
>
>
> Manually tested
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46860: Move RM wizard should update HAWQ related
parameters
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
-----------------------------------------------------------
ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 85)
<https://reviews.apache.org/r/46860/#comment195137>
Unless HAWQ is using YARN as the scheduler, HAWQ may still be functional and we may need not restart HAWQ with the move of RM.
So do you think should we restart it only when HAWQ is using hawq_global_rm_type as yarn ?
- bhuvnesh chaudhary
On April 29, 2016, 11:57 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 11:57 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when RM HA is not enabled, following properties should be updated in hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/reassign/step4_controller.js a20aa82
> ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de
> ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 460726b
>
> Diff: https://reviews.apache.org/r/46860/diff/
>
>
> Testing
> -------
>
> Unit test passed
> Calling set on destroyed view
>
> 27428 tests complete (35 seconds)
> 154 tests pending
>
>
> Manually tested
>
>
> Thanks,
>
> jun aoki
>
>