You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2016/06/30 10:06:12 UTC
spark git commit: [SPARK-12177][TEST] Removed test to avoid
compilation issue in scala 2.10
Repository: spark
Updated Branches:
refs/heads/master b30a2dc7c -> de8ab313e
[SPARK-12177][TEST] Removed test to avoid compilation issue in scala 2.10
## What changes were proposed in this pull request?
The commented lines failed scala 2.10 build. This is because of change in behavior of case classes between 2.10 and 2.11. In scala 2.10, if companion object of a case class has explicitly defined apply(), then the implicit apply method is not generated. In scala 2.11 it is generated. Hence, the lines compile fine in 2.11 but not in 2.10.
This simply comments the tests to fix broken build. Correct solution is pending.
Author: Tathagata Das <ta...@gmail.com>
Closes #13992 from tdas/SPARK-12177.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/de8ab313
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/de8ab313
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/de8ab313
Branch: refs/heads/master
Commit: de8ab313e1fe59f849a62e59349224581ff0b40a
Parents: b30a2dc
Author: Tathagata Das <ta...@gmail.com>
Authored: Thu Jun 30 18:06:04 2016 +0800
Committer: Cheng Lian <li...@databricks.com>
Committed: Thu Jun 30 18:06:04 2016 +0800
----------------------------------------------------------------------
.../spark/streaming/kafka010/JavaConsumerStrategySuite.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/de8ab313/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
----------------------------------------------------------------------
diff --git a/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java b/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
index aba45f5..8d7c05b 100644
--- a/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
+++ b/external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
@@ -50,8 +50,8 @@ public class JavaConsumerStrategySuite implements Serializable {
JavaConverters.mapAsScalaMapConverter(offsets).asScala();
// make sure constructors can be called from java
- final ConsumerStrategy<String, String> sub0 =
- Subscribe.<String, String>apply(topics, kafkaParams, offsets);
+ // final ConsumerStrategy<String, String> sub0 = // does not compile in Scala 2.10
+ // Subscribe.<String, String>apply(topics, kafkaParams, offsets);
final ConsumerStrategy<String, String> sub1 =
Subscribe.<String, String>apply(sTopics, sKafkaParams, sOffsets);
final ConsumerStrategy<String, String> sub2 =
@@ -65,8 +65,8 @@ public class JavaConsumerStrategySuite implements Serializable {
sub1.executorKafkaParams().get("bootstrap.servers"),
sub3.executorKafkaParams().get("bootstrap.servers"));
- final ConsumerStrategy<String, String> asn0 =
- Assign.<String, String>apply(parts, kafkaParams, offsets);
+ // final ConsumerStrategy<String, String> asn0 = // does not compile in Scala 2.10
+ // Assign.<String, String>apply(parts, kafkaParams, offsets);
final ConsumerStrategy<String, String> asn1 =
Assign.<String, String>apply(sParts, sKafkaParams, sOffsets);
final ConsumerStrategy<String, String> asn2 =
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org