You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/07 12:36:45 UTC

[GitHub] [arrow] fredgan commented on a change in pull request #7823: ARROW-9548: [Go] Test output files are not removed correctly

fredgan commented on a change in pull request #7823:
URL: https://github.com/apache/arrow/pull/7823#discussion_r467012651



##########
File path: go/arrow/internal/arrjson/arrjson_test.go
##########
@@ -36,12 +42,11 @@ func TestReadWrite(t *testing.T) {
 			mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
 			defer mem.AssertSize(t, 0)
 
-			f, err := ioutil.TempFile("", "arrjson-")
+			f, err := ioutil.TempFile(tempDir, "arrjson-")

Review comment:
       @sbinet Well, I prefer the test function name. And maybe add "go-arrow-" prefix will be better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org