You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/11/06 15:45:46 UTC

Review Request 40021: Password type property saved with empty value should not be encrypted and auto-filled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40021/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Vitalyi Brodetskyi.


Bugs: AMBARI-13771
    https://issues.apache.org/jira/browse/AMBARI-13771


Repository: ambari


Description
-------

*STR:*
# Deploy Ranger Service with filling all required properties and not changing any other default value of the property
# After ranger installation, Go to Ranger Service->config->Ranger User Info page and enable usersync and change sync source to LDAP
# After that change Bind Anonymous toggle to "Yes"

*Expected Result:* "Bind User Password" field should appear as required and empty field
*Actual Result:* "Bind User password" which was not filled during installation now has pre-filled value


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java d801975 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 8d43349 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/configuration/hdfs-site.xml f53c667 

Diff: https://reviews.apache.org/r/40021/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 40021: Password type property saved with empty value should not be encrypted and auto-filled

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40021/#review105426
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Лис. 6, 2015, 2:45 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40021/
> -----------------------------------------------------------
> 
> (Updated Лис. 6, 2015, 2:45 після полудня)
> 
> 
> Review request for Ambari, Jaimin Jetly and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13771
>     https://issues.apache.org/jira/browse/AMBARI-13771
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *STR:*
> # Deploy Ranger Service with filling all required properties and not changing any other default value of the property
> # After ranger installation, Go to Ranger Service->config->Ranger User Info page and enable usersync and change sync source to LDAP
> # After that change Bind Anonymous toggle to "Yes"
> 
> *Expected Result:* "Bind User Password" field should appear as required and empty field
> *Actual Result:* "Bind User password" which was not filled during installation now has pre-filled value
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java d801975 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 8d43349 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/configuration/hdfs-site.xml f53c667 
> 
> Diff: https://reviews.apache.org/r/40021/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>