You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2018/06/05 03:43:41 UTC

[GitHub] metamodel pull request #181: Don't use Object.finalize()

GitHub user kaspersorensen opened a pull request:

    https://github.com/apache/metamodel/pull/181

    Don't use Object.finalize()

    Since JDK9 the `Object.finalize()` method has been marked as `@Deprecated`. In this PR I removed references to `Objects`s `finalize` method, and tried to get rid of our own `finalize` method where possible without introducing potential issues.
    
    Oh and there was a small junit dependency inconsistency.
    
    I guess I just decided to weed out a couple of warnings really :-)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kaspersorensen/metamodel dont-use-object-finalize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #181
    
----
commit 092c95d24905a29926fff84696e1eebb13b1af9f
Author: Kasper Sørensen <i....@...>
Date:   2018-06-05T03:39:28Z

    Removed referenced to Object.finalize() (deprecated since JDK 9)

commit 3d3750eeff001d81ad49b8edc5e542511a01b64d
Author: Kasper Sørensen <i....@...>
Date:   2018-06-05T03:41:07Z

    Removed duplicate and standardized reference to junit.

----


---

[GitHub] metamodel pull request #181: Don't use Object.finalize()

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/181


---

[GitHub] metamodel issue #181: Don't use Object.finalize()

Posted by kaspersorensen <gi...@git.apache.org>.

Github user kaspersorensen commented on the issue:

    https://github.com/apache/metamodel/pull/181
  
    Build fixed when I merged in master.


---

[GitHub] metamodel issue #181: Don't use Object.finalize()

Posted by kaspersorensen <gi...@git.apache.org>.

Github user kaspersorensen commented on the issue:

    https://github.com/apache/metamodel/pull/181
  
    Self-merging this one based on lazy concensus.


---