You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Cyan4973 <gi...@git.apache.org> on 2017/05/08 20:57:55 UTC

[GitHub] spark pull request #17303: [SPARK-19112][CORE] add codec for ZStandard

Github user Cyan4973 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17303#discussion_r115351567
  
    --- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala ---
    @@ -215,3 +217,22 @@ private final class SnappyOutputStreamWrapper(os: SnappyOutputStream) extends Ou
         }
       }
     }
    +
    +/**
    + * :: DeveloperApi ::
    + * ZStandard implementation of [[org.apache.spark.io.CompressionCodec]].
    + *
    + * @note The wire protocol for this codec is not guaranteed to be compatible across versions
    + * of Spark. This is intended for use as an internal compression utility within a single Spark
    + * application.
    + */
    +@DeveloperApi
    +class ZStandardCompressionCodec(conf: SparkConf) extends CompressionCodec {
    +
    +  override def compressedOutputStream(s: OutputStream): OutputStream = {
    +    val level = conf.getSizeAsBytes("spark.io.compression.zstandard.level", "3").toInt
    --- End diff --
    
    Use cases which favor speed over size should prefer using level 1.
    Compression speed difference is fairly large.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org