You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/04/20 20:29:00 UTC
[jira] [Commented] (SOLR-14185) add
DocSet.getDocIdSetIterator(LeafReaderContext)
[ https://issues.apache.org/jira/browse/SOLR-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326091#comment-17326091 ]
ASF subversion and git services commented on SOLR-14185:
--------------------------------------------------------
Commit bec4ed890b026a23bb537190de7cdbe10b3b1081 in solr's branch refs/heads/main from Michael Gibney
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=bec4ed8 ]
SOLR-14185: introduce DocSet.iterator(LeafReaderContext), replacing Filter where possible (#2)
* fix some brittle code that effectively assumes non-null iterators
* replace Filter with `DocSet.iterator(LeafReaderContext)` where possible
* extend TestDocSet to cover equivalence of direct/getTopFilter DISIs
* IntervalFacets was redundantly checking live bits; stop it
SortedIntDocSet specifically:
* report precise cost for the iterator; no need to approximate
* cache per-segment offsets into the array
* replaced an unnecessary custom binary search implementation with Arrays.binarySearch(...).
* intersection size optimization; return "this" if unchanged
Co-authored-by: David Smiley <ds...@salesforce.com>
> add DocSet.getDocIdSetIterator(LeafReaderContext)
> -------------------------------------------------
>
> Key: SOLR-14185
> URL: https://issues.apache.org/jira/browse/SOLR-14185
> Project: Solr
> Issue Type: Sub-task
> Reporter: David Smiley
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Many callers of {{DocSet.getTopFilter()}} really just want to call {{getDocIdSet}} on the Filter and then call {{iterator()}}. The Bits 2nd arg is also always null or always live-docs so this arg doesn't matter since a Solr DocSet never contains deleted docs. The goal here is to reduce needless dependencies on the old Filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org