You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/14 02:55:17 UTC

[GitHub] [iotdb] Cpaulyz opened a new pull request, #7972: Rename storage group to database in sync module

Cpaulyz opened a new pull request, #7972:
URL: https://github.com/apache/iotdb/pull/7972

   ## Description
   
   * Rename some variables names in sync module from `stroage group` to `database`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #7972: Rename storage group to database in sync module

Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7972:
URL: https://github.com/apache/iotdb/pull/7972


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #7972: Rename storage group to database in sync module

Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7972:
URL: https://github.com/apache/iotdb/pull/7972#discussion_r1021049780


##########
server/src/main/java/org/apache/iotdb/db/sync/SyncService.java:
##########
@@ -400,7 +400,7 @@ public List<TShowPipeInfo> showPipeForReceiver(String pipeName) {
                 SyncConstant.ROLE_RECEIVER,
                 identityInfo.getAddress(),
                 PipeStatus.RUNNING.name(),
-                String.format("storageGroup='%s'", identityInfo.getStorageGroup()),
+                String.format("database='%s'", identityInfo.getDatabase()),

Review Comment:
   ```suggestion
                   String.format("Database='%s'", identityInfo.getDatabase()),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org