You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Abhinandan Prateek <cl...@aprateek.com> on 2013/05/24 07:12:54 UTC
https://reviews.apache.org/r/9539/
Hi Wei,
https://reviews.apache.org/r/9539/ was pending in my review dashboard.
Now that you are a committer I think you can commit it.
I was on a vacation and recently saw it in my queue.
Congrats once again !
-abhi
Re: https://reviews.apache.org/r/9539/
Posted by Abhinandan Prateek <cl...@aprateek.com>.
This patch is reviewed. In fact a similar patch has been committed to
master.
I think you can merge it with 4.0.1.
On 24/05/13 10:48 AM, "Hiroaki KAWAI" <ka...@stratosphere.co.jp> wrote:
>Hi,
>
>I put it on RB because I wanted it to be reviewed by
>someone else. I'll merege by myself after nobody
>seems to review...
>
>(2013/05/24 14:12), Abhinandan Prateek wrote:
>> Hi Wei,
>>
>> https://reviews.apache.org/r/9539/ was pending in my review
>>dashboard.
>> Now that you are a committer I think you can commit it.
>> I was on a vacation and recently saw it in my queue.
>>
>> Congrats once again !
>>
>> -abhi
>>
>>
>>
>
Re: https://reviews.apache.org/r/9539/
Posted by Hiroaki KAWAI <ka...@stratosphere.co.jp>.
Hi,
I put it on RB because I wanted it to be reviewed by
someone else. I'll merege by myself after nobody
seems to review...
(2013/05/24 14:12), Abhinandan Prateek wrote:
> Hi Wei,
>
> https://reviews.apache.org/r/9539/ was pending in my review dashboard.
> Now that you are a committer I think you can commit it.
> I was on a vacation and recently saw it in my queue.
>
> Congrats once again !
>
> -abhi
>
>
>
Re: https://reviews.apache.org/r/9539/
Posted by Wei ZHOU <us...@gmail.com>.
Hi Wido,
Thanks!
Harikrishna has created a clone of this issue, and already committed new
patch for 4.1 branch. Thanks him.
JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-2180
Review: https://reviews.apache.org/r/10772/
-Wei
2013/5/31 Wido den Hollander <wi...@widodh.nl>
> Hi Wei,
>
>
> On 05/31/2013 09:25 AM, Wei Zhou wrote:
>
>> Abhinandan,
>>
>> Thanks!
>> I have committed it to 4.0 branch.
>>
>>
> The agreement is that no commits to both the 4.0 or 4.1 branches are made
> without going through Joe Brockmeier (4.0) or Chip Childers (4.1).
>
> 4.0 is a released version (4.0.2) and there is not going to be a 4.0.3, so
> you bug fixes will never be release in a Apache version.
>
> 4.1 is the next release coming up, but I don't know if these fixes are
> already in 4.1? The vote is currently active for 4.1 and if it passes 4.1
> will be released in the *current* state soon.
>
> If your fixes are not in, they will go into 4.1.1 and obviously 4.2
>
> All commits should go into master and you should sent a cherry-pick
> request to the dev list to get them into a "version branch".
>
> Wido
>
>
> Kind Regards,
>>
>> Wei ZHOU
>> Innovation Engineer Cloud, LeaseWeb B.V.
>> w.zhou@leaseweb.com<mailto:w.**zhou@leaseweb.com <w....@leaseweb.com>>
>>
>> From: Abhinandan Prateek [mailto:cloudstack@aprateek.**com<cl...@aprateek.com>
>> ]
>> Sent: 24 May 2013 07:13
>> To: Wei Zhou
>> Cc: dev@cloudstack.apache.org
>> Subject: https://reviews.apache.org/r/**9539/<https://reviews.apache.org/r/9539/>
>>
>> Hi Wei,
>>
>> https://reviews.apache.org/r/**9539/<https://reviews.apache.org/r/9539/>was pending in my review dashboard. Now that you are a committer I think
>> you can commit it.
>> I was on a vacation and recently saw it in my queue.
>>
>> Congrats once again !
>>
>> -abhi
>>
>>
>
Re: https://reviews.apache.org/r/9539/
Posted by Wido den Hollander <wi...@widodh.nl>.
Hi Wei,
On 05/31/2013 09:25 AM, Wei Zhou wrote:
> Abhinandan,
>
> Thanks!
> I have committed it to 4.0 branch.
>
The agreement is that no commits to both the 4.0 or 4.1 branches are
made without going through Joe Brockmeier (4.0) or Chip Childers (4.1).
4.0 is a released version (4.0.2) and there is not going to be a 4.0.3,
so you bug fixes will never be release in a Apache version.
4.1 is the next release coming up, but I don't know if these fixes are
already in 4.1? The vote is currently active for 4.1 and if it passes
4.1 will be released in the *current* state soon.
If your fixes are not in, they will go into 4.1.1 and obviously 4.2
All commits should go into master and you should sent a cherry-pick
request to the dev list to get them into a "version branch".
Wido
> Kind Regards,
>
> Wei ZHOU
> Innovation Engineer Cloud, LeaseWeb B.V.
> w.zhou@leaseweb.com<ma...@leaseweb.com>
>
> From: Abhinandan Prateek [mailto:cloudstack@aprateek.com]
> Sent: 24 May 2013 07:13
> To: Wei Zhou
> Cc: dev@cloudstack.apache.org
> Subject: https://reviews.apache.org/r/9539/
>
> Hi Wei,
>
> https://reviews.apache.org/r/9539/ was pending in my review dashboard. Now that you are a committer I think you can commit it.
> I was on a vacation and recently saw it in my queue.
>
> Congrats once again !
>
> -abhi
>
RE: https://reviews.apache.org/r/9539/
Posted by Wei Zhou <w....@leaseweb.com>.
Abhinandan,
Thanks!
I have committed it to 4.0 branch.
Kind Regards,
Wei ZHOU
Innovation Engineer Cloud, LeaseWeb B.V.
w.zhou@leaseweb.com<ma...@leaseweb.com>
From: Abhinandan Prateek [mailto:cloudstack@aprateek.com]
Sent: 24 May 2013 07:13
To: Wei Zhou
Cc: dev@cloudstack.apache.org
Subject: https://reviews.apache.org/r/9539/
Hi Wei,
https://reviews.apache.org/r/9539/ was pending in my review dashboard. Now that you are a committer I think you can commit it.
I was on a vacation and recently saw it in my queue.
Congrats once again !
-abhi