[GitHub] myui commented on a change in pull request #178: [HIVEMALL-233] RandomForest regressor accepts sparse vector input

[GitBox <gi...@apache.org>]

myui commented on a change in pull request #178: [HIVEMALL-233] RandomForest regressor accepts sparse vector input
URL: https://github.com/apache/incubator-hivemall/pull/178#discussion_r249087536
 
 

 ##########
 File path: core/src/main/java/hivemall/utils/collections/lists/DoubleArrayList.java
 ##########
 @@ -70,7 +70,7 @@ public DoubleArrayList add(@Nonnull double[] values) {
     private void expand(int max) {
         while (data.length < max) {
             final int len = data.length;
-            double[] newArray = new double[len * 2];
+            double[] newArray = new double[(len + 1) * 2];
 
 Review comment:
   why this change has been made?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services