You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andrew Cox (JIRA)" <ji...@apache.org> on 2012/05/25 22:48:23 UTC
[jira] [Created] (THRIFT-1613) Add code back into empty source file
ToStringTest.java
Andrew Cox created THRIFT-1613:
----------------------------------
Summary: Add code back into empty source file ToStringTest.java
Key: THRIFT-1613
URL: https://issues.apache.org/jira/browse/THRIFT-1613
Project: Thrift
Issue Type: Test
Components: Java - Library
Environment: All java
Reporter: Andrew Cox
Priority: Minor
Fix For: 0.9
Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch
This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1613) Add code back into empty source file
ToStringTest.java
Posted by "Andrew Cox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cox updated THRIFT-1613:
-------------------------------
Attachment: THRIFT-1613-delete-ToStingTest.patch
Adding patch to delete this new file, which apparently was the original intent when all the lines were removed.
It appears that plain "patch" gets confused by this patch, so it should be applied using "svn patch" instead.
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch, THRIFT-1613-delete-ToStingTest.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1613) Add code back into empty source
file ToStringTest.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284145#comment-13284145 ]
Hudson commented on THRIFT-1613:
--------------------------------
Integrated in Thrift #492 (See [https://builds.apache.org/job/Thrift/492/])
THRIFT-1613 Add code back into empty source file ToStringTest.java
Patch: Andrew Cox (Revision 1343032)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1343032
Files :
* /thrift/trunk/lib/java/test/org/apache/thrift/test/ToStringTest.java
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1613) Add code back into empty source
file ToStringTest.java
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1613.
---------------------------------
Resolution: Fixed
thanks Andrew!
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1613) Add code back into empty source
file ToStringTest.java
Posted by "Andrew Cox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284943#comment-13284943 ]
Andrew Cox commented on THRIFT-1613:
------------------------------------
My bad. Brian is right, the same test now lives in org.apache.thrift.TestStruct.
We should delete the old file, then. I'll do so, check that everything is fine, and submit a new patch for it attached to the THRIFT-1613.
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1613) Add code back into empty source
file ToStringTest.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285032#comment-13285032 ]
Hudson commented on THRIFT-1613:
--------------------------------
Integrated in Thrift #494 (See [https://builds.apache.org/job/Thrift/494/])
THRIFT-1613. Add code back into empty source file ToStringTest.java
Actually, should have just deleted the file. (Revision 1343889)
Result = SUCCESS
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1343889
Files :
* /thrift/trunk/lib/java/test/org/apache/thrift/test/ToStringTest.java
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch, THRIFT-1613-delete-ToStingTest.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1613) Add code back into empty source
file ToStringTest.java
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284901#comment-13284901 ]
Bryan Duxbury commented on THRIFT-1613:
---------------------------------------
Hm, I don't know if this is the correct resolution. If the file was empty, then it was probably the result of a deletion patch getting applied. In which case, the solution should be to delete ToStringTest.java, not add its contents back.
My memory is failing me at the moment, but I believe the functionality of that test moved to another testcase. Someone should verify this.
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1613) Add code back into empty source file
ToStringTest.java
Posted by "Andrew Cox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cox updated THRIFT-1613:
-------------------------------
Attachment: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1613) Add code back into empty source
file ToStringTest.java
Posted by "Andrew Cox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cox reopened THRIFT-1613:
--------------------------------
Reopening the issue.
Brian pointed out that the tests have moved, so the correct resolution is to remove the file, rather than refill it.
New patch attached.
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch, THRIFT-1613-delete-ToStingTest.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1613) Add code back into empty source file
ToStringTest.java
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1613.
---------------------------------
Resolution: Fixed
Assignee: Bryan Duxbury
I just deleted the offending file.
> Add code back into empty source file ToStringTest.java
> ------------------------------------------------------
>
> Key: THRIFT-1613
> URL: https://issues.apache.org/jira/browse/THRIFT-1613
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Environment: All java
> Reporter: Andrew Cox
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0001-restore-lib-java-test-org-apache-thrift-test-ToStrin.patch, THRIFT-1613-delete-ToStingTest.patch
>
>
> This test file was emptied but the file was not removed when java fields were converted to use ByteBuffer instead of byte[]. Having an empty file confuses some IDEs. The attached patch just restores the original code, with very slight changes to wrap the byte[] inputs in ByteBuffer to get it working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira