You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <Ma...@mch.sni.de> on 1998/04/03 18:32:02 UTC
Re: [PATCH] Make ports for CONNECT configurable
On Mon, Mar 30, 1998 at 06:44:58PM -0800, sameer wrote:
> So this patch lets you configure the ports that CONNECT lets
> through.
+1 (tested!). This is good stuff -- can you please commit it (with proper
documentation update)?
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [PATCH] Make ports for CONNECT configurable
Posted by Marc Slemko <ma...@worldgate.com>.
On Sun, 5 Apr 1998, Martin Kraemer wrote:
> On Fri, Apr 03, 1998 at 11:56:26AM -0700, Marc Slemko wrote:
> > I am still quite wary of something like this that doesn't include the
> > current allowed ports by default.
>
> Yes, right. By default, it should be backward compatible.
> In your opinion, should that be done by modifying the code, or by
> modifying the default config file? IMO, modifying the httpd.conf-dist
> and noting the change in new_feature_1_3 would be sufficient, no?
When there is a feature that is required for normal usage, we normally
don't require that someone explicitly put something in the config file to
enable it. You have a lot of people upgrading without going through the
new config files, and it is a known fact that people can't read.
While an error message should be added to explicitly refer to the
directive in the error log if an attempt is made that isn't allowed,
I still think adding the default ports in the source is the best way. It
reduces how much you can argue this is just "generic" functionality a bit,
but the patch is still useful because it removes a dumb hardcoded
limitation and does convert it to a more general purpose bit of code.
>
> And there's one typo which I forgot to mention: once the function is
> called "set_allowed_ports()", one it's "set_connect_ports()".
>
> Martin
> --
> | S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
> | ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
> | N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
>
Re: [PATCH] Make ports for CONNECT configurable
Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Fri, Apr 03, 1998 at 11:56:26AM -0700, Marc Slemko wrote:
> I am still quite wary of something like this that doesn't include the
> current allowed ports by default.
Yes, right. By default, it should be backward compatible.
In your opinion, should that be done by modifying the code, or by
modifying the default config file? IMO, modifying the httpd.conf-dist
and noting the change in new_feature_1_3 would be sufficient, no?
And there's one typo which I forgot to mention: once the function is
called "set_allowed_ports()", one it's "set_connect_ports()".
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [PATCH] Make ports for CONNECT configurable
Posted by Marc Slemko <ma...@worldgate.com>.
I am still quite wary of something like this that doesn't include the
current allowed ports by default.
On Fri, 3 Apr 1998, Martin Kraemer wrote:
> On Mon, Mar 30, 1998 at 06:44:58PM -0800, sameer wrote:
> > So this patch lets you configure the ports that CONNECT lets
> > through.
>
> +1 (tested!). This is good stuff -- can you please commit it (with proper
> documentation update)?
>
> Martin
> --
> | S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
> | ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
> | N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
>