You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mgubaidullin (via GitHub)" <gi...@apache.org> on 2024/01/08 22:47:32 UTC
[I] User should be able to limit resources for integration containers in docker [camel-karavan]
mgubaidullin opened a new issue, #1052:
URL: https://github.com/apache/camel-karavan/issues/1052
ex:
```
cpus: "0.5"
mem_reservation: "10M"
mem_limit: "250M"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1968181399
In Kubernetes it is already supported by adding deployment.jkube.yaml file with resource fragment to the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "vidhyasagarj (via GitHub)" <gi...@apache.org>.
vidhyasagarj commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1968095494
Noted @mgubaidullin, Will make the change accordingly. Any plans for adding this feature for kubernetes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "vidhyasagarj (via GitHub)" <gi...@apache.org>.
vidhyasagarj commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1965421914
@mgubaidullin So, if the user wants to change the resource limits from project to project, how will this work ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1965501912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "vidhyasagarj (via GitHub)" <gi...@apache.org>.
vidhyasagarj commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1968311685
Seems like the current **docker-java** api only supports the compose v1 parameters like `cpus`, `cpu_shares/percent`, `mem_limits`, `mem_reservations` etc.
it does not specifically support CPU reservations. Any suggestions on how you want this implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1969270508
Lets keep as it is done. Thanks!
The best solution would be to contribute this stuff to docker-java ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1965244329
1. Karavan in Docker adds `docker-compose.yaml` (from snippets) file for every project created.
2. When user deploys project Karavan uses `docker-compose.yaml` from the project folder and applies to Docker.
3. There are DockerCompose model in https://github.com/apache/camel-karavan/blob/main/karavan-app/src/main/java/org/apache/camel/karavan/model/DockerCompose.java and converted Yaml->DockerCompose https://github.com/apache/camel-karavan/blob/main/karavan-app/src/main/java/org/apache/camel/karavan/code/DockerComposeConverter.java
We need to add these limit resources to the model (and converter if needed)
Also we need to set these limit resources when create container https://github.com/apache/camel-karavan/blob/8a37d39f3788641cdd7e21b5584f6426a994553a/karavan-app/src/main/java/org/apache/camel/karavan/docker/DockerService.java#L187C22-L187C48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin closed issue #1052: User should be able to limit resources for integration containers in docker
URL: https://github.com/apache/camel-karavan/issues/1052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1959575271
@vidhyasagarj could you please take a look on this one? If yes, please add a comment, then I can assign you to the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "vidhyasagarj (via GitHub)" <gi...@apache.org>.
vidhyasagarj commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1960584657
@mgubaidullin, Sure, I will propose a solution approach and take your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] User should be able to limit resources for integration containers in docker [camel-karavan]
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on issue #1052:
URL: https://github.com/apache/camel-karavan/issues/1052#issuecomment-1966834915
@vidhyasagarj thanks.
I made a mistake. It looks like the format was changed in the latest docker-compose https://docs.docker.com/compose/compose-file/compose-file-v3/#resources
```
deploy:
resources:
limits:
cpus: '0.50'
memory: 50M
reservations:
cpus: '0.25'
memory: 20
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org