You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2016/10/11 12:46:24 UTC

[GitHub] tinkerpop pull request #454: TINKERPOP-1469: Get rid of Stream-usage in Trav...

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/454

    TINKERPOP-1469: Get rid of Stream-usage in TraversalHelper

    https://issues.apache.org/jira/browse/TINKERPOP-1469
    
    I went through `TraversalHelper` and removed all usage of `stream()` as well as added various other little nick-nack optimizations along the way.
    I also added some more test cases to `TraversalHelperTest`.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1469

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #454
    
----
commit 9ce3fe86979a5f3452bfcb82ed8642fa1ea291c6
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2016-10-11T12:36:39Z

    removed stream()-usage and unneeded method recurssions in TraversalHelper.

commit 54226cde46b5b96cf756f1b4fb8dc40086c14aec
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2016-10-11T12:44:02Z

    added another test case for getLabels().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #454: TINKERPOP-1469: Get rid of Stream-usage in Trav...

Posted by okram <gi...@git.apache.org>.

Github user okram closed the pull request at:

    https://github.com/apache/tinkerpop/pull/454


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #454: TINKERPOP-1469: Get rid of Stream-usage in TraversalHe...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/454
  
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #454: TINKERPOP-1469: Get rid of Stream-usage in TraversalHe...

Posted by twilmes <gi...@git.apache.org>.

Github user twilmes commented on the issue:

    https://github.com/apache/tinkerpop/pull/454
  
    The conversions and additional changes all look good.
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---