[GitHub] [pinot] deemoliu commented on a diff in pull request #9664: Add updating hdfs url as an option for uploading llc segment

[GitBox <gi...@apache.org>]

deemoliu commented on code in PR #9664:
URL: https://github.com/apache/pinot/pull/9664#discussion_r1006181643


##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -436,7 +436,8 @@ public Response downloadSegment(
   public String uploadLLCSegment(
       @ApiParam(value = "Name of the REALTIME table", required = true) @PathParam("realtimeTableName")
           String realtimeTableName,
-      @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") String segmentName)
+      @ApiParam(value = "Name of the segment", required = true) @PathParam("segmentName") String segmentName,
+      @ApiParam(value = "Whether to update hdfs url") @QueryParam("updateUrl") boolean updateUrl)

Review Comment:
   thanks for review. let me add defaultValue for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org