You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2005/05/06 21:26:07 UTC
Response header fetching in Neon 0.25.0.
In Neon 0.25.0, ne_add_response_header_handler() has been replaced
with ne_get_response_header(). This means that instead of setting a
callback to be invoked by Neon when a given response header is seen,
we just fetch response headers after the request is done, by calling
ne_get_response_header(ne_request *req).
We've mostly completed the process of upgrading Subversion to Neon
0.25.0 (see http://subversion.tigris.org/issues/show_bug.cgi?id=2297),
including fetching response headers as described above.
But there's one place where I don't know how to make that change:
Subversion uses ne_lock(), ne_unlock(), and ne_lock_discover(), all of
which create their own ne_request objects internally. Subversion
never has a chance to get custom headers from the response, because it
never even has a handle on the request object, only on the ne_session.
What should we do?
I looked in ne_lock.h for some sort of callback mechanism, but didn't
see anything.
Thanks
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [neon] Response header fetching in Neon 0.25.0.
Posted by kf...@collab.net.
Joe Orton <jo...@manyfish.co.uk> writes:
> That was true already: ra_dav is using a pre_send hook to register the
> response-header callbacks. With neon 0.25, the response headers can be
> retrieved using ne_get_response_header() from a post_send hook instead.
Ah, ne_*hook* in ne_request.h. Will do -- thanks for the tip!
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [neon] Response header fetching in Neon 0.25.0.
Posted by Joe Orton <jo...@manyfish.co.uk>.
On Fri, May 06, 2005 at 04:26:07PM -0500, Karl Fogel wrote:
> In Neon 0.25.0, ne_add_response_header_handler() has been replaced
> with ne_get_response_header(). This means that instead of setting a
> callback to be invoked by Neon when a given response header is seen,
> we just fetch response headers after the request is done, by calling
> ne_get_response_header(ne_request *req).
>
> We've mostly completed the process of upgrading Subversion to Neon
> 0.25.0 (see http://subversion.tigris.org/issues/show_bug.cgi?id=2297),
> including fetching response headers as described above.
>
> But there's one place where I don't know how to make that change:
> Subversion uses ne_lock(), ne_unlock(), and ne_lock_discover(), all of
> which create their own ne_request objects internally. Subversion
> never has a chance to get custom headers from the response, because it
> never even has a handle on the request object, only on the ne_session.
That was true already: ra_dav is using a pre_send hook to register the
response-header callbacks. With neon 0.25, the response headers can be
retrieved using ne_get_response_header() from a post_send hook instead.
Regards,
joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org