You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 14:19:06 UTC

[GitHub] [arrow] pitrou commented on pull request #14369: ARROW-14656: [Python] Add sort helper function for Array, ChunkedArray and StructArray

pitrou commented on PR #14369:
URL: https://github.com/apache/arrow/pull/14369#issuecomment-1292126171

   Thanks @Jedi18 for attempting this. At a high level, two things:
   
   1) Can you first tackle just the C++ side and write tests on that side?
   
   2)
   > Follow up PRs will update the Table, RecordBatch etc sorting implementations to use this NestedValuesComparator.
   
   Did you actually measure performance? I expect this to be slower that the current RecordBatch and Table sorting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org