You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/15 21:08:06 UTC
[GitHub] [flink-playgrounds] roy-michael opened a new pull request, #35: [FLINK-27513][flink-playgrounds] Update table walkthrough playground for 1.15
roy-michael opened a new pull request, #35:
URL: https://github.com/apache/flink-playgrounds/pull/35
1. Change Flink version to 1.5.2
2. Use Scala free dependencies
3. Add dependency required for tests to run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-playgrounds] alpinegizmo closed pull request #35: [FLINK-27513][flink-playgrounds] Update table walkthrough playground for 1.15
Posted by GitBox <gi...@apache.org>.
alpinegizmo closed pull request #35: [FLINK-27513][flink-playgrounds] Update table walkthrough playground for 1.15
URL: https://github.com/apache/flink-playgrounds/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-playgrounds] roy-michael commented on a diff in pull request #35: [FLINK-27513][flink-playgrounds] Update table walkthrough playground for 1.15
Posted by GitBox <gi...@apache.org>.
roy-michael commented on code in PR #35:
URL: https://github.com/apache/flink-playgrounds/pull/35#discussion_r974607943
##########
table-walkthrough/pom.xml:
##########
@@ -72,9 +72,15 @@ under the License.
<version>${flink.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
this works as well. thanks for the clarification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-playgrounds] alpinegizmo commented on pull request #35: [FLINK-27513][flink-playgrounds] Update table walkthrough playground for 1.15
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on PR #35:
URL: https://github.com/apache/flink-playgrounds/pull/35#issuecomment-1251683148
Merged with 677a4bb892f6eba990617a8ecc699b14b10e7b6a.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-playgrounds] alpinegizmo commented on a diff in pull request #35: [FLINK-27513][flink-playgrounds] Update table walkthrough playground for 1.15
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on code in PR #35:
URL: https://github.com/apache/flink-playgrounds/pull/35#discussion_r974476284
##########
README.md:
##########
@@ -13,7 +13,7 @@ Currently, the following playgrounds are available:
Flink job. The playground is presented in detail in
["Flink Operations Playground"](https://ci.apache.org/projects/flink/flink-docs-release-1.14/docs/try-flink/flink-operations-playground), which is part of the _Try Flink_ section of the Flink documentation.
-* The **Table Walkthrough** (in the `table-walkthrough` folder) shows to use the Table API to build an analytics pipeline that reads streaming data from Kafka and writes results to MySQL, along with a real-time dashboard in Grafana. The walkthrough is presented in detail in ["Real Time Reporting with the Table API"](https://ci.apache.org/projects/flink/flink-docs-release-1.14/docs/try-flink/table_api), which is part of the _Try Flink_ section of the Flink documentation.
+* The **Table Walkthrough** (in the `table-walkthrough` folder) shows to use the Table API to build an analytics pipeline that reads streaming data from Kafka and writes results to MySQL, along with a real-time dashboard in Grafana. The walkthrough is presented in detail in ["Real Time Reporting with the Table API"](https://ci.apache.org/projects/flink/flink-docs-release-1.15/docs/try-flink/table_api), which is part of the _Try Flink_ section of the Flink documentation.
Review Comment:
```suggestion
* The **Table Walkthrough** (in the `table-walkthrough` folder) shows how to use the Table API to build an analytics pipeline that reads streaming data from Kafka and writes results to MySQL, along with a real-time dashboard in Grafana. The walkthrough is presented in detail in ["Real Time Reporting with the Table API"](https://ci.apache.org/projects/flink/flink-docs-release-1.15/docs/try-flink/table_api), which is part of the _Try Flink_ section of the Flink documentation.
```
##########
table-walkthrough/pom.xml:
##########
@@ -72,9 +72,15 @@ under the License.
<version>${flink.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Try this instead -- I think it should work. We want to encourage using the scala-free versions wherever possible.
```suggestion
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-table-planner-loader</artifactId>
<version>${flink.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-table-runtime</artifactId>
<version>${flink.version}</version>
<scope>provided</scope>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org