You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "PDGGK (via GitHub)" <gi...@apache.org> on 2026/10/19 11:58:53 UTC
[PR] Exclude the generated Grafana plugin config from the RAT check [iotdb-extras]
PDGGK opened a new pull request, #140:
URL: https://github.com/apache/iotdb-extras/pull/140
While checking the 2.0.11 RC1 source release I ran the RAT check with every profile enabled. It passes in every module except `connectors/grafana-plugin`, which reports 22 files without a license header:
- 20 files under `.config/`, generated by `@grafana/create-plugin` when I migrated the plugin build in #118
- `.nvmrc`, which holds only the Node.js version
- the empty `provisioning/datasources/.gitkeep`
The check is bound to `verify`, so `mvn verify -Pwith-grafana-plugin` fails. CI runs only `mvn clean package -Pwith-grafana-plugin` for this module, so the check never ran there.
The `.config/` files carry a "do not edit" notice and are rewritten by `npx @grafana/create-plugin update`, so an ASF header added to them would not survive, and they are not ASF-authored anyway. This change:
- excludes those three paths in the module's RAT configuration, appended to the excludes inherited from the root pom
- notes in LICENSE that `connectors/grafana-plugin/.config` comes from create-plugin (Apache License 2.0), next to the existing maven-wrapper entry
Checked with `mvn -pl connectors/grafana-plugin -Pwith-grafana-plugin org.apache.rat:apache-rat-plugin:0.16.1:check@license-check`:
- before: 22 unknown licenses; after: 0
- a header-less file added under `src/` is still reported; one added under `.config/` is not
- the root-pom excludes still apply to this module (`package.json` is not reported)
- RAT across all modules with all profiles enabled passes
- the pom is unchanged by the project's `xml-format` execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org