You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/11 02:31:39 UTC

[GitHub] [spark] ueshin commented on a change in pull request #33687: [SPARK-36370][PYTHON] _builtin_table directly imported from pandas instead of being redefined

ueshin commented on a change in pull request #33687:
URL: https://github.com/apache/spark/pull/33687#discussion_r686445834



##########
File path: python/pyspark/pandas/groupby.py
##########
@@ -44,10 +44,16 @@
     TYPE_CHECKING,
 )
 
-import numpy as np
 import pandas as pd
 from pandas.api.types import is_hashable, is_list_like
 
+if parse_version(pd.__version__) >= parse_version("1.3.0"):

Review comment:
       Shall we use `LooseVersion`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org