You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/05 15:08:28 UTC

[GitHub] [cloudstack] stephankruggg commented on pull request #7061: Rollback of changes with errors during the VM assign

stephankruggg commented on PR #7061:
URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1372338282

   > lots of refactoring. I am not sure if the code is good or not. Maybe others can check.
   > 
   > @stephankruggg can you point out the key point of your change ?
   
   @weizhouapache, when assigning a VM to another account (`assignVirtualMachine API`), if a network error happens during the process, no rollback is executed; thus, leaving the DB in an inconsistent state. This PR fixes this by processing all steps to change the ownership of a VM inside the transaction. 
   
   The refactoring is intended to make the code more testable, readable, and easier to maintain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org