You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/16 11:37:27 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #2692: drivers/syslog: Prepend Process ID to syslog message
anchao opened a new pull request #2692:
URL: https://github.com/apache/incubator-nuttx/pull/2692
## Summary
drivers/syslog: Prepend Process ID to syslog message
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
syslog
## Testing
```
[ 14.618783] Test Initializing...
[ 14.618872] Test initialized
->
[ 14.618783] [7] Test Initializing...
[ 14.618872] [7] Test initialized
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on pull request #2692: drivers/syslog: Prepend Process ID to syslog message
Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #2692:
URL: https://github.com/apache/incubator-nuttx/pull/2692#issuecomment-761621354
@btashton The priority is logged as string, i.e. `[INFO]`, so I believe it is unambiguous.
Only pid is logged as a plain number. So everything can be clear as to what it refers to, regardless of the configuration.
I have no objection to prefixing pid of course... Just saying that it does not seem necessary to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #2692: drivers/syslog: Prepend Process ID to syslog message
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2692:
URL: https://github.com/apache/incubator-nuttx/pull/2692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2692: drivers/syslog: Prepend Process ID to syslog message
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2692:
URL: https://github.com/apache/incubator-nuttx/pull/2692#issuecomment-761623422
@anchao please rebase your patch to resolve the conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2692: drivers/syslog: Prepend Process ID to syslog message
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2692:
URL: https://github.com/apache/incubator-nuttx/pull/2692#issuecomment-761622749
Ah you are right, I was mixing up process priority with debug priority....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2692: drivers/syslog: Prepend Process ID to syslog message
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2692:
URL: https://github.com/apache/incubator-nuttx/pull/2692#issuecomment-761619299
@anchao I am on board with these changes, but it might be work prefixing the pid and priority number somehow so you know what the field is. Right now if only one is enabled you cannot tell what is in the log, maybe something like this?
```
[ 14.618783] [pid-7] [pri-100] Test Initializing...
[ 14.618872] [pid-7] [pri-100] Test initialized
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org