[GitHub] [tvm] areusch opened a new pull request, #11040: Downgrade some LOG(FATAL) in structural_equal

[GitBox <gi...@apache.org>]

areusch opened a new pull request, #11040:
URL: https://github.com/apache/tvm/pull/11040

   It seems like these should be at most `CHECK` or `LOG(ERROR)`; having them as `LOG(FATAL)` made it difficult to debug a pytest crashing on this code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch closed pull request #11040: Downgrade some LOG(FATAL) in structural_equal

[GitBox <gi...@apache.org>]

areusch closed pull request #11040: Downgrade some LOG(FATAL) in structural_equal
URL: https://github.com/apache/tvm/pull/11040


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #11040: Downgrade some LOG(FATAL) in structural_equal

[GitBox <gi...@apache.org>]

areusch commented on PR #11040:
URL: https://github.com/apache/tvm/pull/11040#issuecomment-1101882555

   actually on second thought, i think the problem debugging tests came from a double-check fail solved in #11039 . closing for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org