[GitHub] [flink] pnowojski commented on a change in pull request #10336: [FLINK-14935][task, runtime] Use RunnableWithException in the Mailbox

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #10336: [FLINK-14935][task,runtime] Use RunnableWithException in the Mailbox
URL: https://github.com/apache/flink/pull/10336#discussion_r351315222
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MailboxExecutor.java
 ##########
 @@ -227,21 +226,4 @@ default void execute(@Nonnull Runnable command, String description) {
 	 * @throws IllegalStateException if the mailbox is closed and can no longer supply runnables for yielding.
 	 */
 	boolean tryYield();
-
-	/**
-	 * Provides an {@link Executor} view on this {@code MailboxExecutor}, where submitted tasks will receive the
-	 * given description. The {@link Executor} can be used with {@link java.util.concurrent.CompletableFuture}.
-	 *
-	 * <p>An optional description can (and should) be added to ease debugging and error-reporting. The description
-	 * may contain placeholder that refer to the provided description arguments using {@link java.util.Formatter}
-	 * syntax. The actual description is only formatted on demand.
-	 *
-	 * @param descriptionFormat the optional description for all commands that is used for debugging and
-	 * error-reporting.
-	 * @param descriptionArgs the parameters used to format the final description string.
-	 * @return an {@code Executor} view on this {@code MailboxExecutor}
-	 */
-	default Executor asExecutor(String descriptionFormat, Object... descriptionArgs) {
 
 Review comment:
   It's not used currently anywhere, so I prefered to drop it instead of implementing `Runnable` -> `RunnableWithException` wrapping of the `Executor` interface. Now I see that that's only method (previously I thought it's more), but still - I would prefer to not maintain a dead code. We can re-introduce it later if there will be such demand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services