You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "markap14 (via GitHub)" <gi...@apache.org> on 2026/01/08 21:26:29 UTC

[PR] NIFI-15446: When invoking ConnectorMethod, make sure to serialize/des… [nifi]

markap14 opened a new pull request, #10750:
URL: https://github.com/apache/nifi/pull/10750

   …erialize the arguments and return value
   
   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15446: When invoking ConnectorMethod, make sure to serialize/des… [nifi]

Posted by "sfc-gh-rpaulin (via GitHub)" <gi...@apache.org>.
sfc-gh-rpaulin commented on code in PR #10750:
URL: https://github.com/apache/nifi/pull/10750#discussion_r2687553683


##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java:
##########
@@ -140,7 +142,7 @@
 public class StandardProcessorNode extends ProcessorNode implements Connectable {
 
     private static final Logger LOG = LoggerFactory.getLogger(StandardProcessorNode.class);
-
+    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();

Review Comment:
   Given that objects will likely live in different classloaders should be be more forgiving in what we accept here?  For example should fail fast if unknown properties are found?  Should null values be ignored during serialization?
   
   ```
   private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
   static {
       OBJECT_MAPPER.setDefaultPropertyInclusion(JsonInclude.Include.NON_NULL)
   }
   ```
   
   Ideally these objects should always be kept insync so there is an argument to say failing fast may be preferred.  However in the case where the object passed as the parameter might contain fields not present in the processor/controller service being invoked due to version upgrades etc it might cause us to keep deprecated fields just to prevent errors.
   
   This comment would apply to all the OBJECT_MAPPER objects in the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15446: When invoking ConnectorMethod, make sure to serialize/des… [nifi]

Posted by "bobpaulin (via GitHub)" <gi...@apache.org>.
bobpaulin commented on code in PR #10750:
URL: https://github.com/apache/nifi/pull/10750#discussion_r2687996129


##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java:
##########
@@ -140,7 +142,7 @@
 public class StandardProcessorNode extends ProcessorNode implements Connectable {
 
     private static final Logger LOG = LoggerFactory.getLogger(StandardProcessorNode.class);
-
+    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();

Review Comment:
   Given that objects will likely live in different classloaders should be be more forgiving in what we accept here?  For example should fail fast if unknown properties are found?  Should null values be ignored during serialization?
   
   ```
   private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
   static {
       OBJECT_MAPPER.setDefaultPropertyInclusion(JsonInclude.Include.NON_NULL)
   }
   ```
   
   Ideally these objects should always be kept insync so there is an argument to say failing fast may be preferred.  However in the case where the object passed as the parameter might contain fields not present in the processor/controller service being invoked due to version upgrades etc it might cause us to keep deprecated fields just to prevent errors.
   
   This comment would apply to all the OBJECT_MAPPER objects in the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15446: When invoking ConnectorMethod, make sure to serialize/des… [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman merged PR #10750:
URL: https://github.com/apache/nifi/pull/10750


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15446: When invoking ConnectorMethod, make sure to serialize/des… [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on PR #10750:
URL: https://github.com/apache/nifi/pull/10750#issuecomment-3755370962

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15446: When invoking ConnectorMethod, make sure to serialize/des… [nifi]

Posted by "sfc-gh-rpaulin (via GitHub)" <gi...@apache.org>.
sfc-gh-rpaulin commented on code in PR #10750:
URL: https://github.com/apache/nifi/pull/10750#discussion_r2687553683


##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java:
##########
@@ -140,7 +142,7 @@
 public class StandardProcessorNode extends ProcessorNode implements Connectable {
 
     private static final Logger LOG = LoggerFactory.getLogger(StandardProcessorNode.class);
-
+    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();

Review Comment:
   Given that objects will likely live in different classloaders should be be more forgiving in what we accept here?  For example should fail fast if unknown properties are found?  Should null values be ignored during serialization?
   
   ```
   private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
   static {
       OBJECT_MAPPER.setDefaultPropertyInclusion(JsonInclude.Include.NON_NULL)
   }
   ```
   
   Ideally these objects should always be kept insync so there is an argument to say failing fast may be preferred.  However in the case where the object passed as the parameter might contain fields not present in the processor/controller service being invoked due to version upgrades etc it might cause us to keep deprecated fields just to prevent errors.
   
   This comment would apply to all the OBJECT_MAPPER objects in the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org