You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2023/03/03 13:40:09 UTC

[spark] branch master updated: [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 635d664d8f4 [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
635d664d8f4 is described below

commit 635d664d8f4a97fad8fb2c671f264b9da716fb3d
Author: Hyukjin Kwon <gu...@apache.org>
AuthorDate: Fri Mar 3 22:39:46 2023 +0900

    [SPARK-42653][CONNECT][FOLLOW-UP] Fix Scala 2.13 build failure by explicit Seq conversion
    
    ### What changes were proposed in this pull request?
    
    This PR proposes to add `toSeq` to work around Scala 2.13 build at `getCrcValues`.
    
    ### Why are the changes needed?
    
    The build in the master branch fails in Scala 2.13 build:
    
    ```
    [error] /home/runner/work/spark/spark/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala:87:11: type mismatch;
    [error]  found   : scala.collection.mutable.Buffer[Long]
    [error]  required: Seq[Long]
    [error]       .map(_.toLong)
    [error]           ^
    ```
    
    https://github.com/apache/spark/actions/runs/4323142317/jobs/7546408812
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, dev-only.
    
    ### How was this patch tested?
    
    CI in this PR should test it out.
    
    Closes #40267 from HyukjinKwon/SPARK-42653-followup.
    
    Authored-by: Hyukjin Kwon <gu...@apache.org>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 .../test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala b/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala
index adb2b3f1908..f3d2e5be954 100644
--- a/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala
+++ b/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala
@@ -85,6 +85,7 @@ class ArtifactSuite extends ConnectFunSuite with BeforeAndAfterEach {
       .readAllLines(artifactCrcPath.resolve(crcFileName))
       .asScala
       .map(_.toLong)
+      .toSeq
   }
 
   /**


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org