You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2025/02/23 04:41:53 UTC
[PR] MINOR: Remove zk from replica_verification_test [kafka]
frankvicky opened a new pull request, #19015:
URL: https://github.com/apache/kafka/pull/19015
We could remove zk from the `replica_verification_test` since ak has eliminated zk.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19015:
URL: https://github.com/apache/kafka/pull/19015#issuecomment-2924139628
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #19015:
URL: https://github.com/apache/kafka/pull/19015#discussion_r1966676680
##########
tests/kafkatest/tests/tools/replica_verification_test.py:
##########
@@ -20,7 +20,6 @@
from ducktape.tests.test import Test
from kafkatest.services.verifiable_producer import VerifiableProducer
-from kafkatest.services.zookeeper import ZookeeperService
from kafkatest.services.kafka import KafkaService, quorum
from kafkatest.services.replica_verification_tool import ReplicaVerificationTool
Review Comment:
Could you also rename `num_zk` this field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #19015: MINOR: Remove zk from replica_verification_test
URL: https://github.com/apache/kafka/pull/19015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19015:
URL: https://github.com/apache/kafka/pull/19015#issuecomment-2676635552
I don't dig in it, but this PR seems to cause another failure
```
TimeoutError("Kafka server didn't finish startup in 60 seconds")
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 351, in _do_run
data = self.run_test()
File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 411, in run_test
return self.test_context.function(self.test)
File "/usr/local/lib/python3.7/dist-packages/ducktape/mark/_mark.py", line 438, in wrapper
return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
File "/opt/kafka-dev/tests/kafkatest/tests/tools/replica_verification_test.py", line 76, in test_replica_lags
self.start_kafka(security_protocol, security_protocol)
File "/opt/kafka-dev/tests/kafkatest/tests/tools/replica_verification_test.py", line 52, in start_kafka
self.kafka.start()
File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 668, in start
self.wait_for_start(node, monitor, timeout_sec)
File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 930, in wait_for_start
err_msg="Kafka server didn't finish startup in %d seconds" % timeout_sec)
File "/usr/local/lib/python3.7/dist-packages/ducktape/cluster/remoteaccount.py", line 754, in wait_until
allow_fail=True) == 0, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/ducktape/utils/util.py", line 58, in wait_until
raise TimeoutError(err_msg() if callable(err_msg) else err_msg) from last_exception
ducktape.errors.TimeoutError: Kafka server didn't finish startup in 60 seconds
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #19015:
URL: https://github.com/apache/kafka/pull/19015#issuecomment-2676643156
Hi @chia7712
I have run the test three times with different commits, and they all failed due to `Timed out waiting to reach non-zero number of replica lags.`
Before this patch:
With this patch on my local machine:
With this patch on Jenkins:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #19015:
URL: https://github.com/apache/kafka/pull/19015#discussion_r1966677024
##########
tests/kafkatest/tests/tools/replica_verification_test.py:
##########
@@ -20,7 +20,6 @@
from ducktape.tests.test import Test
from kafkatest.services.verifiable_producer import VerifiableProducer
-from kafkatest.services.zookeeper import ZookeeperService
from kafkatest.services.kafka import KafkaService, quorum
from kafkatest.services.replica_verification_tool import ReplicaVerificationTool
Review Comment:
https://issues.apache.org/jira/browse/KAFKA-18582
This is tracking by this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #19015:
URL: https://github.com/apache/kafka/pull/19015#issuecomment-2692154148
It seems the failed `replica_verification_test` has been fixed by #18852
I have traced the past PRs, and before #18852, the test consistently failed.
cc @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove zk from replica_verification_test [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19015:
URL: https://github.com/apache/kafka/pull/19015#issuecomment-3017681243
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org