You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Berezhniuk (JIRA)" <ji...@apache.org> on 2007/03/09 18:07:09 UTC

[jira] Created: (HARMONY-3350) [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()

[drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()
---------------------------------------------------------------------------

                 Key: HARMONY-3350
                 URL: https://issues.apache.org/jira/browse/HARMONY-3350
             Project: Harmony
          Issue Type: Improvement
          Components: DRLVM
         Environment: windows/em64t
            Reporter: Ilya Berezhniuk


LLI description in lil.h says that parameters described as %di, where d is parameter number, are taken by lil_parse_onto_end() as pointer size integers.
But there are many places where immediate parameters are stored as int, so lil_parse_onto_end() could take garbage in high part of pointer size ints.

I'll attach patch fixing this problem in all found places where LIL is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3350) [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-3350.
----------------------------------------

    Resolution: Fixed

Patch applied at 517198. Please check that it was applied as expected.

> [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-3350
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3350
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Ilya Berezhniuk
>         Assigned To: Gregory Shimansky
>         Attachments: lil_fix2.patch
>
>
> LLI description in lil.h says that parameters described as %di, where d is parameter number, are taken by lil_parse_onto_end() as pointer size integers.
> But there are many places where immediate parameters are stored as int, so lil_parse_onto_end() could take garbage in high part of pointer size ints.
> I'll attach patch fixing this problem in all found places where LIL is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3350) [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-3350.
--------------------------------------


No response, assuming ok.

> [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-3350
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3350
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Ilya Berezhniuk
>            Assignee: Gregory Shimansky
>         Attachments: lil_fix2.patch
>
>
> LLI description in lil.h says that parameters described as %di, where d is parameter number, are taken by lil_parse_onto_end() as pointer size integers.
> But there are many places where immediate parameters are stored as int, so lil_parse_onto_end() could take garbage in high part of pointer size ints.
> I'll attach patch fixing this problem in all found places where LIL is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3350) [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk updated HARMONY-3350:
-------------------------------------

    Attachment: lil_fix2.patch

> [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-3350
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3350
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Ilya Berezhniuk
>         Attachments: lil_fix2.patch
>
>
> LLI description in lil.h says that parameters described as %di, where d is parameter number, are taken by lil_parse_onto_end() as pointer size integers.
> But there are many places where immediate parameters are stored as int, so lil_parse_onto_end() could take garbage in high part of pointer size ints.
> I'll attach patch fixing this problem in all found places where LIL is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3350) [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-3350:
------------------------------------------

    Assignee: Gregory Shimansky

> [drlvm][winx64] Fixed size of immediate parameters for lil_parse_onto_end()
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-3350
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3350
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Ilya Berezhniuk
>         Assigned To: Gregory Shimansky
>         Attachments: lil_fix2.patch
>
>
> LLI description in lil.h says that parameters described as %di, where d is parameter number, are taken by lil_parse_onto_end() as pointer size integers.
> But there are many places where immediate parameters are stored as int, so lil_parse_onto_end() could take garbage in high part of pointer size ints.
> I'll attach patch fixing this problem in all found places where LIL is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.