[GitHub] [superset] FishermanZzhang commented on issue #3829: Cannot create table with same name from a different datasource

[GitBox <gi...@apache.org>]

FishermanZzhang commented on issue #3829:
URL: https://github.com/apache/superset/issues/3829#issuecomment-874605942


   > 
   > ```
   >     __table_args__ = (UniqueConstraint("database_id", "table_name"),)
   > ```
   
   but，the unique only `table_name` , not `dataset_id`
   ```
   sqlite> .schema tables
   CREATE TABLE IF NOT EXISTS "tables" (
           ...
           UNIQUE (table_name),
           FOREIGN KEY(created_by_fk) REFERENCES ab_user (id)
   );
   ```
   as the code say, it show be ` UNIQUE (database_id, table_name)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org