[GitHub] [incubator-pegasus] levy5307 commented on pull request #728: improve performance of count_data

[GitBox <gi...@apache.org>]

levy5307 commented on pull request #728:
URL: https://github.com/apache/incubator-pegasus/pull/728#issuecomment-838074458


   > @ZhongChaoqiang This is good idea. we have discussed it and think that:
   > 
   > 1. add code into `on_scan`  will make this `on_scan`  more bloat, we now planing refactor the `scan` logic
   > 2. use `scan rpc` to count data actually seem not to be a elegant design，would it be better to add a new RPC and only reuse the code of `on_scan`( which need `1` to refactor )
   > 3. cplus shell will be abandoned, the client suggest add into https://github.com/pegasus-kv/admin-cli
   
   I aggree with @Shuo-Jia . Besides count data precisely is not a common used scenario. Count estimates are enough in most cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org