You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2025/12/23 16:29:21 UTC
(doris) branch master updated: [opt](catalog) make catalog createtime the same format as updatetime (#59288)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new faa32ab2d9b [opt](catalog) make catalog createtime the same format as updatetime (#59288)
faa32ab2d9b is described below
commit faa32ab2d9bfc44ca511eb2bb08ca6554bb14bae
Author: camby <10...@qq.com>
AuthorDate: Wed Dec 24 00:29:13 2025 +0800
[opt](catalog) make catalog createtime the same format as updatetime (#59288)
### What problem does this PR solve?
Problem Summary: make Catalog `CreateTime` the same format as
`LastUpdateTime`
**Before Change:**
```
mysql> show catalogs;
+---------------+--------------+----------+-----------+-------------------------------+---------------------+------------------------+----------+
| CatalogId | CatalogName | Type | IsCurrent | CreateTime | LastUpdateTime | Comment | ErrorMsg |
+---------------+--------------+----------+-----------+-------------------------------+---------------------+------------------------+----------+
| 0 | internal | internal | Yes | NULL | NULL | Doris internal catalog | |
| 1766385337200 | paimon_on_s3 | paimon | No | 2025-12-22 14:36:37.728382313 | 2025-12-22 14:36:37 | | |
+---------------+--------------+----------+-----------+-------------------------------+---------------------+------------------------+----------+
```
**After Change:**
```
mysql> show catalogs;
+---------------+--------------+----------+-----------+---------------------+---------------------+------------------------+----------+
| CatalogId | CatalogName | Type | IsCurrent | CreateTime | LastUpdateTime | Comment | ErrorMsg |
+---------------+--------------+----------+-----------+---------------------+---------------------+------------------------+----------+
| 0 | internal | internal | Yes | NULL | NULL | Doris internal catalog | |
| 1766473078905 | paimon_on_s3 | paimon | No | 2025-12-23 14:58:43 | 2025-12-23 14:58:43 | | |
+---------------+--------------+----------+-----------+---------------------+---------------------+------------------------+----------+
```
---
fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java | 5 ++---
.../doris/nereids/trees/plans/commands/CreateCatalogCommand.java | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java
index 1859c09200c..c9d21e7174d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/JdbcResource.java
@@ -26,6 +26,7 @@ import org.apache.doris.common.FeConstants;
import org.apache.doris.common.plugin.CloudPluginDownloader;
import org.apache.doris.common.plugin.CloudPluginDownloader.PluginType;
import org.apache.doris.common.proc.BaseProcResult;
+import org.apache.doris.common.util.TimeUtils;
import org.apache.doris.common.util.Util;
import org.apache.doris.datasource.CatalogProperty;
import org.apache.doris.datasource.ExternalCatalog;
@@ -47,8 +48,6 @@ import java.net.URI;
import java.net.URISyntaxException;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
-import java.time.LocalDateTime;
-import java.time.ZoneId;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
@@ -206,7 +205,7 @@ public class JdbcResource extends Resource {
this.configs = Maps.newHashMap(properties);
validateProperties(this.configs);
applyDefaultProperties();
- String currentDateTime = LocalDateTime.now(ZoneId.systemDefault()).toString().replace("T", " ");
+ String currentDateTime = TimeUtils.longToTimeString(System.currentTimeMillis());
configs.put(CREATE_TIME, currentDateTime);
// check properties
for (String property : ALL_PROPERTIES) {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateCatalogCommand.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateCatalogCommand.java
index 138773108e5..3d1e913296c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateCatalogCommand.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateCatalogCommand.java
@@ -23,6 +23,7 @@ import org.apache.doris.common.Config;
import org.apache.doris.common.ErrorCode;
import org.apache.doris.common.ErrorReport;
import org.apache.doris.common.util.PropertyAnalyzer;
+import org.apache.doris.common.util.TimeUtils;
import org.apache.doris.common.util.Util;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.InternalCatalog;
@@ -35,8 +36,6 @@ import org.apache.doris.qe.StmtExecutor;
import com.google.common.base.Strings;
import com.google.common.collect.Maps;
-import java.time.LocalDateTime;
-import java.time.ZoneId;
import java.util.Map;
import java.util.Objects;
@@ -81,7 +80,7 @@ public class CreateCatalogCommand extends Command implements ForwardWithSync, Ne
+ " to enable it temporarily.");
}
- String currentDateTime = LocalDateTime.now(ZoneId.systemDefault()).toString().replace("T", " ");
+ String currentDateTime = TimeUtils.longToTimeString(System.currentTimeMillis());
properties.put(ExternalCatalog.CREATE_TIME, currentDateTime);
PropertyAnalyzer.checkCatalogProperties(properties, false);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org