You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/28 03:02:10 UTC

[GitHub] [flink] tweise opened a new pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

tweise opened a new pull request #14783:
URL: https://github.com/apache/flink/pull/14783


   ## What is the purpose of the change
   
   Changes the scope of `flink-connector-base` dependency from `provided` to default so that the dependency becomes part of application classpath. Otherwise, it needs to be repeated downstream to be able to use the connector.  
   
   ## Verifying this change
   
   Verified effect of the change by running application within IDE.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14783:
URL: https://github.com/apache/flink/pull/14783#issuecomment-768767423


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ea0fa2c3a97b2d2082b40732850ccc960ba7a09e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12576",
       "triggerID" : "ea0fa2c3a97b2d2082b40732850ccc960ba7a09e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ea0fa2c3a97b2d2082b40732850ccc960ba7a09e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12576) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14783:
URL: https://github.com/apache/flink/pull/14783#issuecomment-768765175

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ea0fa2c3a97b2d2082b40732850ccc960ba7a09e (Thu Jan 28 03:04:31 UTC 2021)

**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14783:
URL: https://github.com/apache/flink/pull/14783#issuecomment-768767423


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ea0fa2c3a97b2d2082b40732850ccc960ba7a09e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12576",
       "triggerID" : "ea0fa2c3a97b2d2082b40732850ccc960ba7a09e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ea0fa2c3a97b2d2082b40732850ccc960ba7a09e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12576) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14783:
URL: https://github.com/apache/flink/pull/14783#issuecomment-768765175

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit ea0fa2c3a97b2d2082b40732850ccc960ba7a09e (Fri May 28 08:15:20 UTC 2021)

**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tweise merged pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

tweise merged pull request #14783:
URL: https://github.com/apache/flink/pull/14783


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14783:
URL: https://github.com/apache/flink/pull/14783#issuecomment-768767423


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ea0fa2c3a97b2d2082b40732850ccc960ba7a09e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ea0fa2c3a97b2d2082b40732850ccc960ba7a09e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ea0fa2c3a97b2d2082b40732850ccc960ba7a09e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tweise commented on pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

tweise commented on pull request #14783:
URL: https://github.com/apache/flink/pull/14783#issuecomment-770499151


   > Hello @tweise and @becketqin ~ I think putting flink-connector-base JAR under lib directory of Flink distribution might be a better choice. After eventually all connectors are migrated to the new source and sink API, almost every job will reference this module as long as the job uses any type of connector, which would be a kind of duplication among all Flink job JARs.
   
   @PatrickRen anything under the lib directory is hard to deal with for users that don't control the Flink distribution. I prefer dependencies under lib to be as slim as possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] PatrickRen commented on pull request #14783: [FLINK-21169][kafka] flink-connector-base dependency should be scope compile

Posted by GitBox <gi...@apache.org>.

PatrickRen commented on pull request #14783:
URL: https://github.com/apache/flink/pull/14783#issuecomment-768833202


   Hello @tweise and @becketqin ~ I think putting flink-connector-base JAR under lib directory of Flink distribution might be a better choice. After eventually all connectors are migrated to the new source and sink API, almost every job will reference this module as long as the job uses any type of connector, which would be a kind of duplication among all Flink job JARs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org