You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/12/08 15:19:03 UTC
Review Request 64450: Update docs to mention new
'--reconfiguration_policy' flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Update docs to mention new flag.
Diffs
-----
CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de
docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36
docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95
Diff: https://reviews.apache.org/r/64450/diff/1/
Testing
-------
One pass of proof-reading.
Thanks,
Benno Evers
Re: Review Request 64450: Update docs to mention new
'--reconfiguration_policy' flag.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64450/#review193283
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Reviews applied: `['64450']`
Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64450
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64450/logs/libprocess-tests-stdout.log):
```
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" (17386 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (16434 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (35165 ms total)
[----------] Global test environment tear-down
[==========] 223 tests from 35 test cases ran. (264044 ms total)
[ PASSED ] 209 tests.
[ FAILED ] 14 tests, listed below:
[ FAILED ] SSLTest.SSLSocket
[ FAILED ] SSLTest.NonSSLSocket
[ FAILED ] SSLTest.NoVerifyBadCA
[ FAILED ] SSLTest.RequireBadCA
[ FAILED ] SSLTest.VerifyBadCA
[ FAILED ] SSLTest.VerifyCertificate
[ FAILED ] SSLTest.ProtocolMismatch
[ FAILED ] SSLTest.ECDHESupport
[ FAILED ] SSLTest.ValidDowngrade
[ FAILED ] SSLTest.NoValidDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
[ FAILED ] SSLTest.NoValidDowngradeEachProtocol
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false"
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true"
14 FAILED TESTS
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64450/logs/libprocess-tests-stderr.log):
```
I1208 23:33:31.420940 7236 process.cpp:887] Failed to accept socket: future discarded
I1208 23:33:31.606940 5068 process.cpp:887] Failed to accept socket: future discarded
I1208 23:33:32.406971 316 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 23:33:32.406971 316 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 23:33:32.408023 316 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\MgNXUB\cert.pem
I1208 23:33:32.408023 316 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\MgNXUB
I1208 23:33:32.874967 316 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 23:33:32.875226 316 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1208 23:33:32.875226 316 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 23:33:32.892244 316 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\rg5aLY\cert.pem
I1208 23:33:32.892244 316 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\rg5aLY
I1208 23:33:34.275704 316 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1208 23:33:34.275704 316 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 23:33:34.276703 316 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 23:33:34.276703 316 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\GaymFg\cert.pem
I1208 23:33:50.737365 316 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1208 23:33:50.738363 316 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 23:33:50.738363 316 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1208 23:33:50.738363 316 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 23:33:50.739362 316 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\NKi1AT\cert.pem
I1208 23:34:06.924795 6788 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 8, 2017, 3:19 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64450/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 3:19 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update docs to mention new flag.
>
>
> Diffs
> -----
>
> CHANGELOG 8b3d3642c50a60b6ce0f9d27031c2077254473de
> docs/agent-recovery.md 35cd5b1a38a099d87ab337df116b7356fcaa7c36
> docs/configuration/agent.md d629912e391cebd88c9d0daeabc3bbf436344e95
>
>
> Diff: https://reviews.apache.org/r/64450/diff/1/
>
>
> Testing
> -------
>
> One pass of proof-reading.
>
>
> Thanks,
>
> Benno Evers
>
>