You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by kk...@apache.org on 2017/05/16 12:28:45 UTC
flink git commit: [FLINK-6381] [connector] Unnecessary synchronizing
object in BucketingSink.
Repository: flink
Updated Branches:
refs/heads/master 06dff8121 -> 5fc37f8ac
[FLINK-6381] [connector] Unnecessary synchronizing object in BucketingSink.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/5fc37f8a
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/5fc37f8a
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/5fc37f8a
Branch: refs/heads/master
Commit: 5fc37f8ac3293f8fa231cbd2905d15b29edc156c
Parents: 06dff81
Author: zhangminglei <zm...@163.com>
Authored: Thu May 4 15:11:20 2017 +0800
Committer: kkloudas <kk...@gmail.com>
Committed: Tue May 16 14:27:13 2017 +0200
----------------------------------------------------------------------
.../streaming/connectors/fs/bucketing/BucketingSink.java | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/5fc37f8a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
----------------------------------------------------------------------
diff --git a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
index 20e54b8..58dd4dc 100644
--- a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
+++ b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
@@ -724,9 +724,7 @@ public class BucketingSink<T>
handlePendingFilesForPreviousCheckpoints(bucketState.pendingFilesPerCheckpoint);
- synchronized (bucketState.pendingFilesPerCheckpoint) {
- bucketState.pendingFilesPerCheckpoint.clear();
- }
+ bucketState.pendingFilesPerCheckpoint.clear();
}
}
@@ -741,9 +739,7 @@ public class BucketingSink<T>
handlePendingFilesForPreviousCheckpoints(restoredState.pendingFilesPerCheckpoint);
- synchronized (restoredState.pendingFilesPerCheckpoint) {
- restoredState.pendingFilesPerCheckpoint.clear();
- }
+ restoredState.pendingFilesPerCheckpoint.clear();
}
private void handlePendingInProgressFile(String file, long validLength) {