You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2011/03/17 06:20:29 UTC
[jira] Created: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Replace hard-coded option strings with variables from DFSConfigKeys
-------------------------------------------------------------------
Key: HDFS-1763
URL: https://issues.apache.org/jira/browse/HDFS-1763
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Eli Collins
Assignee: Eli Collins
Priority: Minor
Fix For: 0.23.0
There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022517#comment-13022517 ]
Hudson commented on HDFS-1763:
------------------------------
Integrated in Hadoop-Hdfs-trunk #643 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/])
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1763:
------------------------------
Attachment: hdfs-1763-1.patch
Patch attached.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins closed HDFS-1763.
-----------------------------
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008650#comment-13008650 ]
Hudson commented on HDFS-1763:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #565 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/565/])
Add import missed in HDFS-1763.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008621#comment-13008621 ]
Hudson commented on HDFS-1763:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #564 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/564/])
HDFS-1763. Replace hard-coded option strings with variables from DFSConfigKeys. Contributed by Eli Collins
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008534#comment-13008534 ]
Hadoop QA commented on HDFS-1763:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12473881/hdfs-1763-1.patch
against trunk revision 1082263.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 162 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
-1 contrib tests. The patch failed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/273//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/273//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/273//console
This message is automatically generated.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007825#comment-13007825 ]
Todd Lipcon commented on HDFS-1763:
-----------------------------------
Looks good - went through looking for bloopers and didn't see any. In 3 or 4 tests, they were setting dfs.block.size and now are setting the correct dfs.blocksize - it's probably the correct change, but worth being aware of that we're changing behavior of those tests.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008636#comment-13008636 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1763:
----------------------------------------------
Hi Eli, there are some compilation errors in [build #274|https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274/console]. I also saw it in my machine after svn update.
{noformat}
[exec] -compile-fault-inject:
[exec] [echo] Start weaving aspects in place
[exec] [iajc] /grid/0/hudson/hudson-slave/workspace/PreCommit-HDFS-Build/trunk/src/test/aop/org/apache/hadoop/fs/TestFiRename.java:63 [error] DFSConfigKeys cannot be resolved
[exec] [iajc] CONF.setLong(DFSConfigKeys.DFS_BLOCK_SIZE_KEY, 1);
[exec] [iajc] ^^^^^^^^
[exec] [iajc]
[exec] [iajc] 1 error
[exec]
[exec] BUILD FAILED
{noformat}
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008651#comment-13008651 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1763:
----------------------------------------------
No problem. Good work, Eli!
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1763:
------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007826#comment-13007826 ]
Todd Lipcon commented on HDFS-1763:
-----------------------------------
(+1 when test results come back)
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1763:
------------------------------
Status: Open (was: Patch Available)
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1763:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've committed this.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008646#comment-13008646 ]
Eli Collins commented on HDFS-1763:
-----------------------------------
Thanks Nicholas, I've committed the fix (TestFiRename just needed to import DFSConfigKeys).
I forgot that compile-fault-inject does not run as part of test-patch and Hudson. Filed HADOOP-7200 to cover that so we won't get positive runs from Hudson if the patch causes the FI tests to not compile.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008610#comment-13008610 ]
Hadoop QA commented on HDFS-1763:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474023/hdfs-1763-2.patch
against trunk revision 1083021.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 165 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/274//console
This message is automatically generated.
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1763:
------------------------------
Attachment: hdfs-1763-2.patch
Patch attached (minor update of last one that missed a couple imports of DFSConfigKeys in tests).
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1763) Replace hard-coded option strings with
variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1763:
------------------------------
Status: Patch Available (was: Open)
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1763) Replace hard-coded option strings
with variables from DFSConfigKeys
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008614#comment-13008614 ]
Eli Collins commented on HDFS-1763:
-----------------------------------
Test failure is HDFS-1666 (hdfsproxy).
> Replace hard-coded option strings with variables from DFSConfigKeys
> -------------------------------------------------------------------
>
> Key: HDFS-1763
> URL: https://issues.apache.org/jira/browse/HDFS-1763
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hdfs-1763-1.patch, hdfs-1763-2.patch
>
>
> There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira