You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/08/15 17:46:09 UTC

[GitHub] [couchdb] zachlankton opened a new pull request, #4146: update devcontainer

zachlankton opened a new pull request, #4146:
URL: https://github.com/apache/couchdb/pull/4146

   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   This PR is to bring the `devconatiner` in this repo up to date and improve its reliability.  The current config uses outdated dependencies and does not work out of the box.
   
   Here are the updates:
   
   - Use volume mount instead of bind to improve performance and help solve #4145 
   - Updated `README` and `README-DEV` to include quick buttons/links to spin up devcontainer
   - Automatically run `./configure && make` during container creation
   
   ## Testing performed to validate dev container...
   
   Click the button below to automatically spin up a devcontainer on your local machine.
   
   (this demo button uses [zachlankton/couchdb-test](https://github.com/zachlankton/couchdb-test) repo to show how the button will work once this PR is merged into main)
   
   [![Open in Remote - Containers](https://img.shields.io/static/v1?label=Remote%20-%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/zachlankton/couchdb-test)
   
   Once the container is finished setting up (will take some time due to automatically running `./configure && make` run the following commands to verify everything works:
   
   ```bash
   ./dev/run
   # login to http://localhost:15984/_utils/
   # make a db and some docs
   # run the "Verify Install"
   
   # CTRL-C when you are satisfied
   # then run
   make check
   
   # all test should pass!
   ```
   
   
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [n/a] Changes are covered by tests
   - [n/a] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [n/a] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #4146: Update devcontainer

Posted by GitBox <gi...@apache.org>.
nickva merged PR #4146:
URL: https://github.com/apache/couchdb/pull/4146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] big-r81 commented on a diff in pull request #4146: Update devcontainer

Posted by GitBox <gi...@apache.org>.
big-r81 commented on code in PR #4146:
URL: https://github.com/apache/couchdb/pull/4146#discussion_r946701535


##########
.devcontainer/Dockerfile:
##########
@@ -1,24 +1,13 @@
-ARG ELIXIR_VERSION
-FROM elixir:${ELIXIR_VERSION}
+ARG IMG
+FROM ${IMG}

Review Comment:
   Maybe change the variable name to something more descriptive, like 'COUCHDB_IMAGE' or whatever you like.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] zachlankton commented on a diff in pull request #4146: Update devcontainer

Posted by GitBox <gi...@apache.org>.
zachlankton commented on code in PR #4146:
URL: https://github.com/apache/couchdb/pull/4146#discussion_r946792346


##########
.devcontainer/Dockerfile:
##########
@@ -1,24 +1,13 @@
-ARG ELIXIR_VERSION
-FROM elixir:${ELIXIR_VERSION}
+ARG IMG
+FROM ${IMG}

Review Comment:
   Will do!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] big-r81 commented on a diff in pull request #4146: Update devcontainer

Posted by GitBox <gi...@apache.org>.
big-r81 commented on code in PR #4146:
URL: https://github.com/apache/couchdb/pull/4146#discussion_r946704047


##########
README-DEV.rst:
##########
@@ -64,6 +64,21 @@ associated ``devcontainer.json`` file to quickly provision a
 development environment using `GitHub Codespaces <https://github.com/features/codespaces>`_
 or `Visual Studio Code <https://code.visualstudio.com/docs/remote/containers>`_.
 
+
+.. image:: https://img.shields.io/static/v1?label=Remote%20-%20Containers&message=Open&color=blue&logo=visualstudiocode
+    :target: https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/apache/couchdb
+
+If you already have VS Code and Docker installed, you can click the badge above or 
+`here <https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/apache/couchdb>`_ 
+to get started. Clicking these links will cause VS Code to automatically install the 
+Remote - Containers extension if needed, clone the source code into a container volume, 
+and spin up a dev container for use.
+
+This ``devcontainer`` will automatically run ``./configure && make`` the first time it is created.  
+While this may take some extra time to spin up, this tradeoff means you will be able to 
+run things like ``./dev/run`` and ``make check`` straight away.  Subsequent startups should be quick.

Review Comment:
   I think we need to give `./dev/run` and admin user with password or the switch `--with-admin-party-please`. Do you tried it with only `./dev/run`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] zachlankton commented on a diff in pull request #4146: Update devcontainer

Posted by GitBox <gi...@apache.org>.
zachlankton commented on code in PR #4146:
URL: https://github.com/apache/couchdb/pull/4146#discussion_r946805573


##########
README-DEV.rst:
##########
@@ -64,6 +64,21 @@ associated ``devcontainer.json`` file to quickly provision a
 development environment using `GitHub Codespaces <https://github.com/features/codespaces>`_
 or `Visual Studio Code <https://code.visualstudio.com/docs/remote/containers>`_.
 
+
+.. image:: https://img.shields.io/static/v1?label=Remote%20-%20Containers&message=Open&color=blue&logo=visualstudiocode
+    :target: https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/apache/couchdb
+
+If you already have VS Code and Docker installed, you can click the badge above or 
+`here <https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/apache/couchdb>`_ 
+to get started. Clicking these links will cause VS Code to automatically install the 
+Remote - Containers extension if needed, clone the source code into a container volume, 
+and spin up a dev container for use.
+
+This ``devcontainer`` will automatically run ``./configure && make`` the first time it is created.  
+While this may take some extra time to spin up, this tradeoff means you will be able to 
+run things like ``./dev/run`` and ``make check`` straight away.  Subsequent startups should be quick.

Review Comment:
   It works with all of the above, I've tried them all.  Would you like this to be updated to show all three examples? Or just one of them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org