You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/08 22:23:09 UTC
[GitHub] [druid] gianm opened a new pull request #11893: Remove StorageAdapter.getColumnTypeName.
gianm opened a new pull request #11893:
URL: https://github.com/apache/druid/pull/11893
It was only used by SegmentAnalyzer, and isn't necessary anymore due to
the recent improvements to ColumnCapabilities.
Also: tidy ColumnDescriptor.read slightly by removing an instanceof
check, and moving the relevant logic into ComplexColumnPartSerde.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11893: Remove StorageAdapter.getColumnTypeName.
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11893:
URL: https://github.com/apache/druid/pull/11893#discussion_r745275959
##########
File path: processing/src/main/java/org/apache/druid/segment/serde/ComplexMetrics.java
##########
@@ -69,4 +69,16 @@ public static void registerSerde(String type, ComplexMetricSerde serde)
}
});
}
+
+ /**
+ * Unregister a serde name -> ComplexMetricSerde mapping.
+ *
+ * If the spedified serde key string is not in use, does nothing.
Review comment:
```suggestion
* If the specified serde key string is not in use, does nothing.
```
##########
File path: processing/src/main/java/org/apache/druid/segment/serde/ComplexColumnPartSerde.java
##########
@@ -78,12 +78,14 @@ public Serializer getSerializer()
public Deserializer getDeserializer()
{
return (buffer, builder, columnConfig) -> {
+ // we don't currently know if complex column can have nulls (or can be multi-valued, but not making that change
+ // since it isn't supported anywhere in the query engines)
+ // longer term this needs to be captured by making the serde provide this information, and then this should
+ // no longer be set to true but rather the actual values
+ builder.setHasNulls(ColumnCapabilities.Capable.TRUE);
+ builder.setComplexTypeName(typeName);
Review comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #11893: Remove StorageAdapter.getColumnTypeName.
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #11893:
URL: https://github.com/apache/druid/pull/11893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org