You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/05 18:02:14 UTC
[GitHub] [netbeans] ehsavoie opened a new pull request #2000: Adding full
support for Wildfly 17, 18
ehsavoie opened a new pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000
Fixing issue with missing JavaEE 8 web profile
Removing exteernla downloads and updating schemas
This should bring full WildFly support back into the contributed plugin for Apache NetBeans
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390657216
##########
File path: contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd
##########
@@ -0,0 +1,572 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<xsd:schema xmlns="http://www.w3.org/2001/XMLSchema"
+ targetNamespace="http://www.jboss.com/xml/ns/javaee"
+ xmlns:javaee="http://java.sun.com/xml/ns/javaee"
+ xmlns:jboss="http://www.jboss.com/xml/ns/javaee"
+ xmlns:xsd="http://www.w3.org/2001/XMLSchema"
+ elementFormDefault="qualified"
+ attributeFormDefault="unqualified"
+ version="6.0">
+
+ <xsd:annotation>
+ <xsd:documentation> JBoss, Home of Professional Open Source Copyright 2005, JBoss Inc., and
+ individual contributors as indicated by the @authors tag. See the copyright.txt in the
+ distribution for a full listing of individual contributors. This is free software; you can
+ redistribute it and/or modify it under the terms of the GNU Lesser General Public License as
Review comment:
LGPL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390906147
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
Review comment:
It would be useful to comment out the LGPL stuff and replace what you can replace with a better license (like Apache 2.0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on issue #2000: Adding full support
for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-601699754
@emilianbold @matthiasblaesing all licenses have been cleared :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r393871759
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
Review comment:
I'm almost done :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2000: Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390632831
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
+ <comment type="CATEGORY_B" />
+ </fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-ejb3-2_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="COMMENT_UNSUPPORTED" />
Review comment:
That is not correct:
a) XSD support license header
b) Are these XSDs really donated to the ASF? If so, who donates them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on issue #2000: Adding full support
for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-598175488
I think some of the 'offending' schemas are for old versions. I'm not sure they are required for newer versions of WildFly. One solution also could be to download them at build time. Would that be sufficient ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2000: Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r392367462
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
+ <comment type="CATEGORY_B" />
+ </fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-ejb3-2_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="COMMENT_UNSUPPORTED" />
Review comment:
The "ref" points to the license in the nbbuild/licenses folder. For each license there can the full text be found. In this case "Apache-2.0-ASF" starts with "Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements." That statement would be wrong for foreign code, so the correct variant is "Apache-2.0".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2000: Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390632366
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
+ <comment type="CATEGORY_B" />
Review comment:
LGPL-v2.1 is not CATEGORY_B - it is CATEGORY_X. If I remember correctly the DTDs and XSDs are the whole reason, that we can't release the plugin under the ASF umbrella. Which is the reason, that the plugin was moved to the contrib folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on issue #2000: Adding full support
for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-603152077
@matthiasblaesing may you merge this PR please ? So that we can move this plugin back into the main project ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390656027
##########
File path: contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/config/gen/package-info.java
##########
@@ -58,8 +58,38 @@
docRoot="jboss-app",
java5=true
),
+// @Schema2Beans(
+// schema="../../resources/jboss-ejb3-2_1.xsd",
+// schemaType=SchemaType.XML_SCHEMA,
+// outputType=OutputType.TRADITIONAL_BASEBEAN,
+// validate=true,
+// attrProp=true,
+// removeUnreferencedNodes=true,
+// docRoot="enterprise-beans",
+// java5=true
Review comment:
Are these comments something we could enable in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on issue #2000: Adding full
support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-598345657
> If I remember correctly, the Schemas and DTDs are used to create code that is build and my understanding is, that the license transcends from the Schema to the generated code. This would mean, that we could not release the plugin from Apache NetBeans.
As somebody that doesn't even do JavaEE and doesn't even care about any particular web server, let alone JBoss or Wildfly, my angle here is:
1. How can we add Wildfly back to the official NetBeans tree so it gets released to all the users.
2. How can we make it easy so older JBoss / Wildfly versions with problematic schemas are supported for users.
The answer to 1. seems easy: we just don't include the old schemas and we re-add the plugin to NetBeans using only the schemas that are acceptable (under and Apache 2.0 license, or whatever).
For an answer to 2 we have to get creative, the same way we did it for nb-javac and other situations. My idea is that a 2nd "companion" plugin could be added perhaps to the plugin portal. This 2nd plugin would register "somewhere" (if it's just schema, perhaps in a layer file, if it's also generated code then some sort of service in the lookup) the old stuff which the Wildfly plugin would pick up and expand its support to all versions.
In the end, maybe this PR shouldn't even have to fix both 1 and 2. I think just getting 1 would be progress.
So how about @ehsavoie just deletes the license-wise non-compliant schemas and updates the PR? Then we have a PR that is acceptable and we can move the plugin from contrib/ back into NetBeans. Later on @ehsavoie can make a PR for whatever hooks are necessary for the companion plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r393871997
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
+ <comment type="CATEGORY_B" />
+ </fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-ejb3-2_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="COMMENT_UNSUPPORTED" />
Review comment:
ok, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390845524
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
Review comment:
Yes
I can update some (like wildfly-messaging-activemq-deployment_1_0.xsd can be moved to ASL 2.0) I can also remove some of them but then we would loose support for old JBoss / WildFly versions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2000: Adding full
support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on issue #2000: Adding full
support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-597876017
> What we can do is to keep the ALv2 in the contrib directory, LGPL dependencies at build time and not release the module - some one else would need to do it.
Maybe @ehsavoie can explain some more but according to hist post [here](https://github.com/apache/netbeans/pull/2000#discussion_r390845524):
> I can also remove some of them but then we would loose support for old JBoss / WildFly versions
... we can have a plugin that is part of NetBeans proper. NetBeans will just only support more recent JBoss/WildFly version.
Personally I would also prefer to keep and comment out the LGPL schema names/references (not LGPLed content) so it become super easy to make a build of the plugin that supports older version too (in case people really need to search for it).
I think it's important to move this module from contrib/ back into NetBeans and support (modern) JBoss/WildFly out of the box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r396112853
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +44,23 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <license ref="LGPL-2.1" />
Review comment:
this is a mistake it should be 1.4.1 which is EL1.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2000: Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r395869196
##########
File path: contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/xml.xsd
##########
@@ -1,111 +1,107 @@
<?xml version='1.0'?>
-<!--
Review comment:
Please keep the license information - it makes it easier to reason about the code and if I remember correctly, we have multiple copies of the xml.xsd and they all should have the header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r392078283
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
+ <comment type="CATEGORY_B" />
+ </fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-ejb3-2_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="COMMENT_UNSUPPORTED" />
Review comment:
No they are not donated to ASF but are under ASL 2.0 license they can be incorporated and also because of this license not donation is required right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390657042
##########
File path: contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd
##########
@@ -0,0 +1,122 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+ ~ JBoss, Home of Professional Open Source.
+ ~ Copyright 2011, Red Hat, Inc., and individual contributors
+ ~ as indicated by the @author tags. See the copyright.txt file in the
+ ~ distribution for a full listing of individual contributors.
+ ~
+ ~ This is free software; you can redistribute it and/or modify it
+ ~ under the terms of the GNU Lesser General Public License as
Review comment:
Again LGPL, Apache can't use it. No other variant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on issue #2000: Adding full
support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-598178408
> One solution also could be to download them at build time. Would that be sufficient ?
I don't think so, because then the binary would have LGPL stuff, but perhaps @matthiasblaesing can confirm.
I think another option would be to add an user action which does this download. If it's done by the user on the user's machine then Apache is fine with it.
Another option would be to invent some layer location or service provider that provides these schemas. Then users install the plugin with the modern schemas but can easily install a 2nd plugin (eg. `Wilfly extra`) which includes the other schema files. I would prefer this option compared to an user UI action but your call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold edited a comment on issue #2000: Adding full
support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold edited a comment on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-598345657
> If I remember correctly, the Schemas and DTDs are used to create code that is build and my understanding is, that the license transcends from the Schema to the generated code. This would mean, that we could not release the plugin from Apache NetBeans.
As somebody that doesn't even do JavaEE and doesn't even care about any particular web server, let alone JBoss or Wildfly, my angle here is:
1. How can we add Wildfly back to the official NetBeans tree so it gets released to all the users.
2. How can we make it easy so older JBoss / Wildfly versions with problematic schemas are supported for users.
The answer to 1. seems easy: we just don't include the old schemas and we re-add the plugin to NetBeans using only the schemas that are acceptable (under an Apache 2.0 license, or whatever).
For an answer to 2 we have to get creative, the same way we did it for nb-javac and other situations. My idea is that a 2nd "companion" plugin could be added perhaps to the plugin portal. This 2nd plugin would register "somewhere" (if it's just schema, perhaps in a layer file, if it's also generated code then some sort of service in the lookup) the old stuff which the Wildfly plugin would pick up and expand its support to all versions.
In the end, maybe this PR shouldn't even have to fix both 1 and 2. I think just getting 1 would be progress.
So how about @ehsavoie just deletes the license-wise non-compliant schemas and updates the PR? Then we have a PR that is acceptable and we can move the plugin from contrib/ back into NetBeans. Later on @ehsavoie can make a PR for whatever hooks are necessary for the companion plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390655767
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
Review comment:
I think LGPL is category X for Apache. Can you confirm the license?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r390836241
##########
File path: contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/config/gen/package-info.java
##########
@@ -58,8 +58,38 @@
docRoot="jboss-app",
java5=true
),
+// @Schema2Beans(
+// schema="../../resources/jboss-ejb3-2_1.xsd",
+// schemaType=SchemaType.XML_SCHEMA,
+// outputType=OutputType.TRADITIONAL_BASEBEAN,
+// validate=true,
+// attrProp=true,
+// removeUnreferencedNodes=true,
+// docRoot="enterprise-beans",
+// java5=true
Review comment:
I don't think those are required at all. i should remove them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on issue #2000: Adding full support
for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
ehsavoie commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-602696232
I've found the icon under EPL 2.0 in jboss-tools-server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #2000: Adding full
support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#issuecomment-598282611
My understand is this: If we only need the Schema files at runtime, we could use them from an installed jboss, but it becomes problematic when we base code on the XSDs. If I remember correctly, the Schemas and DTDs are used to create code that is build and my understanding is, that the license transcends from the Schema to the generated code. This would mean, that we could not release the plugin from Apache NetBeans.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#2000: Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r395867852
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +44,23 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <license ref="LGPL-2.1" />
Review comment:
LGPL-2.1 is Category-X, i.e. we can't use/redistribute it. https://www.apache.org/legal/resolved.html#category-x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] emilianbold commented on a change in pull request #2000:
Adding full support for Wildfly 17, 18
Posted by GitBox <gi...@apache.org>.
emilianbold commented on a change in pull request #2000: Adding full support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r392090755
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
+ <comment type="CATEGORY_B" />
+ </fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_8_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-ejb3-2_1.xsd</file>
+ <file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="COMMENT_UNSUPPORTED" />
Review comment:
I think `ref="Apache-2.0-ASF"` means owned by Apache Software Foundation.
I guess you can use `ref="Apache-2.0"` for stuff under Apache 2.0 owned by somebody else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists