You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "viola.lu (JIRA)" <ji...@apache.org> on 2009/05/19 05:30:45 UTC
[jira] Created: (GERONIMODEVTOOLS-571) "Next" or "Finish" Button
displays when required fields are not selected or checked during convert
plugin
"Next" or "Finish" Button displays when required fields are not selected or checked during convert plugin
---------------------------------------------------------------------------------------------------------
Key: GERONIMODEVTOOLS-571
URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571
Project: Geronimo-Devtools
Issue Type: Bug
Components: eclipse-plugin
Affects Versions: 2.1.4
Reporter: viola.lu
Assignee: Tim McConnell
1.Right-click "Open" definded server on GEP, and click "plugin" ->"convert app to plugin"->choose folder, "next" button displays but user should check either button below it and then can go to next step.
2.Right-click "Open" definded server on GEP, and click "plugin" ->"Create Custom Assebmly"->"Finish" button displays even if no any inputs.It should be grey if requried fields are not filled out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-571) "Next" or "Finish" Button
displays when required fields are not selected or checked during convert
plugin
Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Jain updated GERONIMODEVTOOLS-571:
-----------------------------------------
Attachment: GERONIMODEVTOOLS-571.patch
I do not see any issues with the 1) . However 2) can prompt user of an invalid selection which is covered in this patch. Please verify thanks.
> "Next" or "Finish" Button displays when required fields are not selected or checked during convert plugin
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-571
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.4
> Reporter: viola.lu
> Assignee: Tim McConnell
> Priority: Minor
> Attachments: GERONIMODEVTOOLS-571.patch
>
>
> 1.Right-click "Open" definded server on GEP, and click "plugin" ->"convert app to plugin"->choose folder, "next" button displays but user should check either button below it and then can go to next step.
> 2.Right-click "Open" definded server on GEP, and click "plugin" ->"Create Custom Assebmly"->"Finish" button displays even if no any inputs.It should be grey if requried fields are not filled out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMODEVTOOLS-571) "Next" or "Finish" Button
displays when required fields are not selected or checked during convert
plugin
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Delos Dai resolved GERONIMODEVTOOLS-571.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0
2.1.5
"Finish" button can only be enabled when all the text fields are filled with characters. Meanwhile, there must be plugins selected in the table.
Ashish, your patch will pop up a new message dialog to tell user not leave them empty. But grayed button can avoid a popped up dialog.
#812442 for 2.1.5 branch and #812441 for trunk
> "Next" or "Finish" Button displays when required fields are not selected or checked during convert plugin
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-571
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.4
> Reporter: viola.lu
> Assignee: Tim McConnell
> Priority: Minor
> Fix For: 2.1.5, 2.2.0
>
> Attachments: GERONIMODEVTOOLS-571.patch
>
>
> 1.Right-click "Open" definded server on GEP, and click "plugin" ->"convert app to plugin"->choose folder, "next" button displays but user should check either button below it and then can go to next step.
> 2.Right-click "Open" definded server on GEP, and click "plugin" ->"Create Custom Assebmly"->"Finish" button displays even if no any inputs.It should be grey if requried fields are not filled out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-571) "Next" or "Finish" Button
displays when required fields are not selected or checked during convert
plugin
Posted by "viola.lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
viola.lu updated GERONIMODEVTOOLS-571:
--------------------------------------
Priority: Minor (was: Major)
> "Next" or "Finish" Button displays when required fields are not selected or checked during convert plugin
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-571
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.4
> Reporter: viola.lu
> Assignee: Tim McConnell
> Priority: Minor
>
> 1.Right-click "Open" definded server on GEP, and click "plugin" ->"convert app to plugin"->choose folder, "next" button displays but user should check either button below it and then can go to next step.
> 2.Right-click "Open" definded server on GEP, and click "plugin" ->"Create Custom Assebmly"->"Finish" button displays even if no any inputs.It should be grey if requried fields are not filled out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-571) "Next" or "Finish" Button
displays when required fields are not selected or checked during convert
plugin
Posted by "Chi Runhua (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755952#action_12755952 ]
Chi Runhua commented on GERONIMODEVTOOLS-571:
---------------------------------------------
Hi, I just tried this feature on GEP_Build_0916 with Galileo.
When I arrived at the panel to add license file, *Finish* button is disable. Then I have to click *Next* button to continue. After that, GEP gives me the very first panel to select a local repository without any prompt.
It's kinda confusing. I hope this can be improved.
Any comments?
Jeff C
> "Next" or "Finish" Button displays when required fields are not selected or checked during convert plugin
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-571
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-571
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.1.4
> Reporter: viola.lu
> Assignee: Tim McConnell
> Priority: Minor
> Fix For: 2.1.5, 2.2.0
>
> Attachments: GERONIMODEVTOOLS-571.patch
>
>
> 1.Right-click "Open" definded server on GEP, and click "plugin" ->"convert app to plugin"->choose folder, "next" button displays but user should check either button below it and then can go to next step.
> 2.Right-click "Open" definded server on GEP, and click "plugin" ->"Create Custom Assebmly"->"Finish" button displays even if no any inputs.It should be grey if requried fields are not filled out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.