You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/26 04:53:00 UTC

[GitHub] [shardingsphere-elasticjob] rudy2steiner opened a new pull request #1271: Avoid NPE log on DaemonTaskSchedulerTest#assertInit test case

rudy2steiner opened a new pull request #1271:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1271


   Fixes #1259
   
   Changes proposed in this pull request:
   - Shutdown task scheduler at the end of assertInit
   
   The test case DaemonTaskSchedulerTest#assertInit doesn't init DaemonTaskScheduler instance parameters correctly, such as shardingContexts, elasticJob, which caused NPE. But there isn't any exception log if we only run the test case independently. Because the task has no chance to execute. The exception only happens at the task runtime
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1271: Avoid NPE log on DaemonTaskSchedulerTest#assertInit test case

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #1271:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1271


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org