You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "rmannibucau (via GitHub)" <gi...@apache.org> on 2025/10/06 19:35:45 UTC
[PR] Follow up of 459 [maven-dependency-plugin]
rmannibucau opened a new pull request, #1536:
URL: https://github.com/apache/maven-dependency-plugin/pull/1536
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Your pull request should address just one issue, without pulling in other changes.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [X] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [X] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Follow up of 459 [maven-dependency-plugin]
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #1536:
URL: https://github.com/apache/maven-dependency-plugin/pull/1536#issuecomment-5615544097
[auto] outdated PR, autoclosing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Follow up of 459 [maven-dependency-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #1536:
URL: https://github.com/apache/maven-dependency-plugin/pull/1536#issuecomment-5399385703
Rebasing this on master stops at a decision rather than a merge conflict, so I left it alone.
Two files conflict, and the one that matters is `AbstractAnalyzeMojo.filterDependencies`. This branch changes its return from `Set<Artifact>` to `List<Artifact>` and drops the empty-excludes short-circuit that master has since added. Choosing a side changes the method's contract and its callers, which is not something to settle on your behalf.
The branch is 8 commits with subjects such as "some draft of a more generic detection of used _unused_ dependencies". If it is still exploratory, cutting a fresh branch from master may be less work than carrying this one forward.
*This comment was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Follow up of 459 [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1536:
URL: https://github.com/apache/maven-dependency-plugin/pull/1536#discussion_r2408648619
##########
pom.xml:
##########
@@ -65,7 +65,7 @@ under the License.
</contributors>
<prerequisites>
- <maven>3.6.3</maven>
+ <maven>${mavenVersion}</maven>
Review Comment:
please don't change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Follow up of 459 [maven-dependency-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #1536:
URL: https://github.com/apache/maven-dependency-plugin/pull/1536#issuecomment-5399288920
The last CI run on this branch was 2025-10-06, and GitHub has deleted the logs since, so there's no way to tell whether the change still builds against master.
A rebase triggers a fresh run and makes the state readable again. If you'd rather not carry it forward, closing is equally useful — the PR isn't being ignored, it's unreadable.
The branch also conflicts with master now, so that needs resolving before CI can say anything. Say the word if you'd like a hand with it.
*This comment was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Follow up of 459 [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1536:
URL: https://github.com/apache/maven-dependency-plugin/pull/1536#discussion_r2408642150
##########
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:
##########
@@ -449,6 +466,125 @@ private boolean checkDependencies() throws MojoExecutionException {
return warning;
}
+ // todo: enhance analyzer (dependency) to do it since it already visits classes
+ // will save some time
+ private Set<String> scanForSpiUsage(
+ final Set<Artifact> usedDeclared, final Map<Artifact, Set<String>> usedUndeclaredWithClasses) {
+ return Stream.concat(
+ usedDeclared.stream().flatMap(this::findUsedSpi),
+ usedUndeclaredWithClasses.keySet().stream().flatMap(this::findUsedSpi))
+ .collect(toSet());
+ }
+
+ private Stream<String> findUsedSpi(final Artifact artifact) {
Review Comment:
Can we extends a [maven-dependency-analyzer](https://github.com/apache/maven-dependency-analyzer) with such feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Follow up of 459 [maven-dependency-plugin]
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau closed pull request #1536: Follow up of 459
URL: https://github.com/apache/maven-dependency-plugin/pull/1536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org