You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/23 20:01:40 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

pkarashchenko commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002763737


##########
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##########
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
 #ifdef CONFIG_BOARD_LATE_INITIALIZE
 void board_late_initialize(void)
 {
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)

Review Comment:
   seems like `LIB_BOARDCTL` is leftover from renaming. Probably we need to clean-up all the places and do not introduce new dependencies



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org