You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/26 08:48:00 UTC

[jira] [Work logged] (ARTEMIS-2682) OpenWireMessageConverter refactoring

     [ https://issues.apache.org/jira/browse/ARTEMIS-2682?focusedWorklogId=410147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410147 ]

ASF GitHub Bot logged work on ARTEMIS-2682:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Mar/20 08:47
            Start Date: 26/Mar/20 08:47
    Worklog Time Spent: 10m 
      Work Description: fvaleri commented on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-604304058
 
 
   > The main point is this needs a jira. Its not a small change
   
   Agree and now you have it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 410147)
    Remaining Estimate: 0h
            Time Spent: 10m

> OpenWireMessageConverter refactoring
> ------------------------------------
>
>                 Key: ARTEMIS-2682
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2682
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: OpenWire
>    Affects Versions: 2.12.0
>            Reporter: Federico Valeri
>            Priority: Minor
>              Labels: openwire, refactoring
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I'm proposing the {{OpenWireMessageConverter}} refactoring to have a similar layout as the {{AMQPConverter}}. The latter has two dedicated classes for inbound and outbound messages with a singleton entry point for the converter. This change is basically doing the same without semantics change and also adding a unit test for the converter. I'm also eliminating some duplicated code, but the bulk of the code remains untouched.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)