You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/07 09:34:33 UTC
[GitHub] [flink] HuangXingBo commented on a change in pull request #13334: [FLINK-19131][python] Add py38 support in PyFlink
HuangXingBo commented on a change in pull request #13334:
URL: https://github.com/apache/flink/pull/13334#discussion_r484305112
##########
File path: docs/dev/python/table-api-users-guide/udfs/vectorized_python_udfs.md
##########
@@ -30,7 +30,7 @@ These Python libraries are highly optimized and provide high-performance data st
[non-vectorized user-defined functions]({% link dev/python/table-api-users-guide/udfs/python_udfs.md %}) on how to define vectorized user-defined functions.
Users only need to add an extra parameter `udf_type="pandas"` in the decorator `udf` to mark it as a vectorized user-defined function.
-**NOTE:** Python UDF execution requires Python version (3.5, 3.6 or 3.7) with PyFlink installed. It's required on both the client side and the cluster side.
+**NOTE:** Python UDF execution requires Python version (3.5, 3.6, 3.7 or 3.8) with PyFlink installed. It's required on both the client side and the cluster side.
Review comment:
The corresponding content of `vectorized_python_udfs.zh.md` also needs to be modified together
##########
File path: flink-python/src/main/java/org/apache/flink/python/metric/FlinkMetricContainer.java
##########
@@ -106,9 +106,12 @@ private void updateMetrics(String stepName) {
private boolean isUserMetric(MetricResult metricResult) {
MetricName metricName = metricResult.getKey().metricName();
+ String urn = ((MonitoringInfoMetricName) metricName).getUrn();
return (metricName instanceof MonitoringInfoMetricName) &&
- ((MonitoringInfoMetricName) metricName).getUrn()
- .contains(MonitoringInfoConstants.Urns.USER_COUNTER);
+ (urn.contains(MonitoringInfoConstants.Urns.USER_SUM_INT64) ||
Review comment:
Since we can ensure that metricName is `MonitoringInfoMetricName`, we can remove the judgment of metricName instanceof `MonitoringInfoMetricName`
##########
File path: docs/dev/python/table-api-users-guide/udfs/python_udfs.md
##########
@@ -25,7 +25,7 @@ under the License.
User-defined functions are important features, because they significantly extend the expressiveness of Python Table API programs.
-**NOTE:** Python UDF execution requires Python version (3.5, 3.6 or 3.7) with PyFlink installed. It's required on both the client side and the cluster side.
+**NOTE:** Python UDF execution requires Python version (3.5, 3.6, 3.7 or 3.8) with PyFlink installed. It's required on both the client side and the cluster side.
Review comment:
The corresponding content of `python_udfs.zh.md` also needs to be modified together
##########
File path: docs/ops/cli.zh.md
##########
@@ -126,7 +126,7 @@ option.
Review comment:
```suggestion
请执行以下命令以确认当前环境下的指令“python”指向Python的版本为3.5, 3.6, 3.7 或者 3.8中的一个
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org