You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/12/12 19:49:02 UTC

Review Request: SQOOP-765 Sqoop2: JDBC repository is incorrectly checking if job exists in update handler

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8555/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've fixed incorrect method call.


This addresses bug SQOOP-765.
    https://issues.apache.org/jira/browse/SQOOP-765


Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 6dc8baa 

Diff: https://reviews.apache.org/r/8555/diff/


Testing
-------


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-765 Sqoop2: JDBC repository is incorrectly checking if job exists in update handler

Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8555/#review14388
-----------------------------------------------------------

Ship it!


Ship It!

- Cheolsoo Park


On Dec. 12, 2012, 6:49 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8555/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 6:49 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've fixed incorrect method call.
> 
> 
> This addresses bug SQOOP-765.
>     https://issues.apache.org/jira/browse/SQOOP-765
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 6dc8baa 
> 
> Diff: https://reviews.apache.org/r/8555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-765 Sqoop2: JDBC repository is incorrectly checking if job exists in update handler

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8555/#review14364
-----------------------------------------------------------


Looks good

- Venkat Ranganathan


On Dec. 12, 2012, 6:49 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8555/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 6:49 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've fixed incorrect method call.
> 
> 
> This addresses bug SQOOP-765.
>     https://issues.apache.org/jira/browse/SQOOP-765
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 6dc8baa 
> 
> Diff: https://reviews.apache.org/r/8555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>