You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/21 06:24:46 UTC
[GitHub] [pinot] klsince opened a new pull request, #8943: add a util method to sanity check time size instead of using regex
klsince opened a new pull request, #8943:
URL: https://github.com/apache/pinot/pull/8943
This PR adds a util method to replace the regex matches based sanity check on `time size` in date time spec. The regex matches can be very costly when converting date time values for segment generation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on pull request #8943: add a util method to sanity check time size instead of using regex
Posted by GitBox <gi...@apache.org>.
klsince commented on PR #8943:
URL: https://github.com/apache/pinot/pull/8943#issuecomment-1161325933
this PR seems not necessary with: https://github.com/apache/pinot/pull/8939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on pull request #8943: add a util method to sanity check time size instead of using regex
Posted by GitBox <gi...@apache.org>.
klsince commented on PR #8943:
URL: https://github.com/apache/pinot/pull/8943#issuecomment-1161318251
<img width="1407" alt="image" src="https://user-images.githubusercontent.com/61892277/174730835-3ddc258f-d927-4d96-aeab-e3e9717d7b97.png">
```
Benchmark (_totalCount) Mode Cnt Score Error Units
BenchmarkTimeSizeCheck.useCompiledPattern 100000 avgt 5 7304.817 ± 1574.564 us/op
BenchmarkTimeSizeCheck.useCompiledPattern:·jfr 100000 avgt NaN ---
BenchmarkTimeSizeCheck.useRegexString 100000 avgt 5 24047.471 ± 12731.113 us/op
BenchmarkTimeSizeCheck.useRegexString:·jfr 100000 avgt NaN ---
BenchmarkTimeSizeCheck.useUtilMethod 100000 avgt 5 2493.348 ± 1181.530 us/op
BenchmarkTimeSizeCheck.useUtilMethod:·jfr 100000 avgt NaN ---
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince closed pull request #8943: add a util method to sanity check time size instead of using regex
Posted by GitBox <gi...@apache.org>.
klsince closed pull request #8943: add a util method to sanity check time size instead of using regex
URL: https://github.com/apache/pinot/pull/8943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org