You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/11/10 10:10:42 UTC

[kudu-CR] WIP: KUDU-2994: don't use mini chrony in kudu-binary

Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14685

to look at the new patch set (#2).

Change subject: WIP: KUDU-2994: don't use mini_chrony in kudu-binary
......................................................................

WIP: KUDU-2994: don't use mini_chrony in kudu-binary

We can't distribute our patched chrony binaries because they're licensed
under the GPLv3. As such, a minicluster started via kudu-binary fails with
an error like this:

  java.io.IOException: failed to start NTP server 0: Unable to canonicalize /tmp/kudu-binary-jar14954881897801164502/kudu-binary-1.11.0-linux-x86_64/bin/chronyd: No such file or directory
	at org.apache.kudu.test.cluster.MiniKuduCluster.sendRequestToCluster(MiniKuduCluster.java:169)
	at org.apache.kudu.test.cluster.MiniKuduCluster.start(MiniKuduCluster.java:234)

To fix this, let's further condition mini_chrony usage in the minicluster
framework on whether the chrony binaries are available or not.

WIP because I have no idea if this makes sense or is the optimal solution; I
just wanted to get something resembling a fix out ASAP.

Change-Id: I2d503634acf837eb3066851dfe9b942e61a77b34
---
M src/kudu/clock/test/mini_chronyd.cc
M src/kudu/clock/test/mini_chronyd.h
M src/kudu/mini-cluster/external_mini_cluster.cc
3 files changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/14685/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d503634acf837eb3066851dfe9b942e61a77b34
Gerrit-Change-Number: 14685
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)