[GitHub] twalthr commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207504462
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/WindowAggregateReduceFunctionsRule.scala
 ##########
 @@ -55,19 +58,12 @@ class WindowAggregateReduceFunctionsRule extends AggregateReduceFunctionsRule(
       newAgg))
   }
 
-  override def newCalcRel(
-      relBuilder: RelBuilder,
-      oldAgg: Aggregate,
-      exprs: util.List[RexNode]): Unit = {
-
-    // add all named properties of the window to the selection
-    val oldWindowAgg = oldAgg.asInstanceOf[LogicalWindowAggregate]
-    oldWindowAgg.getNamedProperties.foreach(np => exprs.add(relBuilder.field(np.name)))
-
-    // create a LogicalCalc that computes the complex aggregates and forwards the window properties
-    relBuilder.project(exprs, oldAgg.getRowType.getFieldNames)
+  override def newCalcRel(relBuilder: RelBuilder, rowType: RelDataType, exprs: util.List[RexNode]) {
 
 Review comment:
   Please format the code again and add some inline comments to know what is happening here. Add `:Unit` as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services