You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Aleksandar Bircakovic (JIRA)" <ji...@apache.org> on 2015/09/08 15:42:45 UTC
[jira] [Commented] (SAMZA-436) Update RocksDB KV's putAll to use
write batch
[ https://issues.apache.org/jira/browse/SAMZA-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734807#comment-14734807 ]
Aleksandar Bircakovic commented on SAMZA-436:
---------------------------------------------
Discussion about writebatch call crash is closed so if you think it should be used in putAll here is that piece of code.
RB: https://reviews.apache.org/r/38180/
> Update RocksDB KV's putAll to use write batch
> ---------------------------------------------
>
> Key: SAMZA-436
> URL: https://issues.apache.org/jira/browse/SAMZA-436
> Project: Samza
> Issue Type: Bug
> Components: kv
> Reporter: Chris Riccomini
> Assignee: Aleksandar Bircakovic
>
> In SAMZA-236, we don't use write batch inside our RocksDB putAll implementation. Instead, we call put sequentially. The reason for this is [this|https://github.com/facebook/rocksdb/issues/262] issue that we were seeing, where RocksDB putAll crashes.
> Once the issue is resolved, we should update our RocksDB implementation to use the proper writeBatch API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)