You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Vinod Kone (JIRA)" <ji...@apache.org> on 2013/04/24 02:21:16 UTC
[jira] [Commented] (MESOS-449) CgroupsTests don't do proper cleanup
[ https://issues.apache.org/jira/browse/MESOS-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639891#comment-13639891 ]
Vinod Kone commented on MESOS-449:
----------------------------------
That doesn't sound correct or is a bug we need to fix. Can you explain why you think ASSERT_FUTURE_WILL_SUCCEED will not wait for cgroups to be destroyed?
> CgroupsTests don't do proper cleanup
> ------------------------------------
>
> Key: MESOS-449
> URL: https://issues.apache.org/jira/browse/MESOS-449
> Project: Mesos
> Issue Type: Bug
> Reporter: Thomas Marshall
>
> On Ubuntu 12.04, I get failures similar to the following:
> [----------] 1 test from CgroupsNoHierarchyTest
> [ RUN ] CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy
> ../../src/tests/cgroups_tests.cpp:250: Failure
> cgroups::mount(TEST_CGROUPS_HIERARCHY, "cpu,memory"): 'cpu' is already attached to another hierarchy
> [ FAILED ] CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy (0 ms)
> [----------] 1 test from CgroupsNoHierarchyTest (0 ms total)
> [----------] 1 test from CgroupsAnyHierarchyWithCpuAcctMemoryTest
> [ RUN ] CgroupsAnyHierarchyWithCpuAcctMemoryTest.ROOT_CGROUPS_Stat
> ../../src/tests/cgroups_tests.cpp:116: Failure
> cgroups::mount(TEST_CGROUPS_HIERARCHY, subsystems): 'memory' is already attached to another hierarchy
> -------------------------------------------------------------
> We cannot run any cgroups tests that require
> a hierarchy with subsystems 'cpuacct,memory'
> because we failed to find an existing hierarchy
> or create a new one. You can either remove all existing
> hierarchies, or disable this test case
> (i.e., --gtest_filter=-CgroupsAnyHierarchyWithCpuAcctMemoryTest.*).
> -------------------------------------------------------------
> ../../src/tests/cgroups_tests.cpp:147: Failure
> exists: '' is not a valid hierarchy
> [ FAILED ] CgroupsAnyHierarchyWithCpuAcctMemoryTest.ROOT_CGROUPS_Stat (0 ms)
> [----------] 1 test from CgroupsAnyHierarchyWithCpuAcctMemoryTest (0 ms total)
> [----------] 3 tests from CgroupsAnyHierarchyWithCpuMemoryFreezerTest
> [ RUN ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Freeze
> ../../src/tests/cgroups_tests.cpp:116: Failure
> cgroups::mount(TEST_CGROUPS_HIERARCHY, subsystems): 'cpu' is already attached to another hierarchy
> -------------------------------------------------------------
> We cannot run any cgroups tests that require
> a hierarchy with subsystems 'cpu,memory,freezer'
> because we failed to find an existing hierarchy
> or create a new one. You can either remove all existing
> hierarchies, or disable this test case
> (i.e., --gtest_filter=-CgroupsAnyHierarchyWithCpuMemoryFreezerTest.*).
> -------------------------------------------------------------
> ../../src/tests/cgroups_tests.cpp:147: Failure
> exists: '' is not a valid hierarchy
> [ FAILED ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Freeze (1 ms)
> [ RUN ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Kill
> ../../src/tests/cgroups_tests.cpp:116: Failure
> cgroups::mount(TEST_CGROUPS_HIERARCHY, subsystems): 'cpu' is already attached to another hierarchy
> -------------------------------------------------------------
> We cannot run any cgroups tests that require
> a hierarchy with subsystems 'cpu,memory,freezer'
> because we failed to find an existing hierarchy
> or create a new one. You can either remove all existing
> hierarchies, or disable this test case
> (i.e., --gtest_filter=-CgroupsAnyHierarchyWithCpuMemoryFreezerTest.*).
> -------------------------------------------------------------
> ../../src/tests/cgroups_tests.cpp:147: Failure
> exists: '' is not a valid hierarchy
> [ FAILED ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Kill (1 ms)
> [ RUN ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Destroy
> ../../src/tests/cgroups_tests.cpp:116: Failure
> cgroups::mount(TEST_CGROUPS_HIERARCHY, subsystems): 'cpu' is already attached to another hierarchy
> -------------------------------------------------------------
> We cannot run any cgroups tests that require
> a hierarchy with subsystems 'cpu,memory,freezer'
> because we failed to find an existing hierarchy
> or create a new one. You can either remove all existing
> hierarchies, or disable this test case
> (i.e., --gtest_filter=-CgroupsAnyHierarchyWithCpuMemoryFreezerTest.*).
> -------------------------------------------------------------
> ../../src/tests/cgroups_tests.cpp:147: Failure
> exists: '' is not a valid hierarchy
> [ FAILED ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Destroy (0 ms)
> [----------] 3 tests from CgroupsAnyHierarchyWithCpuMemoryFreezerTest (2 ms total)
> [----------] Global test environment tear-down
> [==========] 19 tests from 6 test cases ran. (12691 ms total)
> [ PASSED ] 14 tests.
> [ FAILED ] 5 tests, listed below:
> [ FAILED ] CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy
> [ FAILED ] CgroupsAnyHierarchyWithCpuAcctMemoryTest.ROOT_CGROUPS_Stat
> [ FAILED ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Freeze
> [ FAILED ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Kill
> [ FAILED ] CgroupsAnyHierarchyWithCpuMemoryFreezerTest.ROOT_CGROUPS_Destroy
>
> I believe this is because the ASSERT_FUTURE_WILL_SUCCEED in Cgroups*Test::TearDown() doesn't actually wait for the cgroups to be clean up, meaning sometimes the next test starts before the previous tests cgroups are destroyed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira